-
Notifications
You must be signed in to change notification settings - Fork 19
chore : add a devfile for using project from Cloud Develpment Environments #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @rohanKanojia. Thanks for your PR. I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
e6462d0 to
01f500d
Compare
| # Contributors: | ||
| # Red Hat, Inc. - initial API and implementation | ||
| # | ||
| FROM quay.io/devfile/universal-developer-image:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we use quay.io/devfile/base-developer-image:ubi9-latest instead? Since it is a smaller image that only includes the essentials for Che
01f500d to
b688bf3
Compare
b688bf3 to
700983c
Compare
|
@dkwon17 : I'm sorry for noticing it this late...I just realized that the push secrets for I can now see that the GitHub Workflow web-terminal-operator/.github/workflows/dockerimage-next.yml Lines 74 to 75 in 2022108
I have updated |
|
/retest |
.devfile.yaml
Outdated
| # | ||
| # SPDX-License-Identifier: EPL-2.0 | ||
| # | ||
| schemaVersion: 2.2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| schemaVersion: 2.2.0 | |
| schemaVersion: 2.3.0 |
| tags: | | ||
| ${{ env.PUSH_REGISTRY }}/${{ secrets.QUAY_USERNAME }}/web-terminal-operator-devtools:latest | ||
| ${{ env.PUSH_REGISTRY }}/${{ secrets.QUAY_USERNAME }}/web-terminal-operator-devtools:sha-${{ steps.git-sha.outputs.sha }} | ||
| file: ./build/dockerfiles/devtools.Dockerfile No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we please add a newline at the end of this file?
700983c to
9b9da29
Compare
|
/retest |
|
@rohanKanojia: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
/retest |
| ENV OPM_VERSION="v1.13.1" | ||
| RUN curl -sSLO https://github.com/operator-framework/operator-registry/releases/download/${OPM_VERSION}/linux-amd64-opm && \ | ||
| chmod +x linux-amd64-opm && \ | ||
| mv linux-amd64-opm /usr/local/bin/opm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I didn't realize that the base-developer-image doesn't have oc installed.
Could we install it here?
ENV OC_VERSION=4.19
RUN curl -L https://mirror.openshift.com/pub/openshift-v4/x86_64/clients/ocp/stable-${OC_VERSION}/openshift-client-linux.tar.gz; | \
tar -C /usr/local/bin -xz --no-same-owner && \
chmod +x /usr/local/bin/oc
8106955 to
ef0ba61
Compare
…ments Signed-off-by: Rohan Kumar <[email protected]>
ef0ba61 to
307c272
Compare
What does this PR do?
Update: No need to add additional secrets, There are secrets already added in this repository that can be reused in Devtools image push workflow
In order to make GitHub action for building and pushing tooling container image, we need to add these Secrets to GitHub Actions configuration:-PUSH_PASSWORD: password for pusing toquay.io/wtoIt adds a Devfile (plus the tooling container Dockerfile and the GH to build it) that has a couple of commands to:
I was facing some issues with
make uninstalltarget, I have made some modifications in Makefile :workspaceroutings.controller.devfile.io, Probably it was renamed but we forgot to update it's reference. I've renamed it todevworkspaceroutings.controller.devfile.iocomponents.controller.devfile.io, I removed step for uninstalling itdevworkspace-controllerinopenshift-operatorsnamespace, I removed step for uninstalling ituninstall_v1_2, I've removed it from READMEWhat issues does this PR fix or reference?
It's a part of #173
Is it tested? How?
Go to Eclipse Che Dashboard and open this project https://github.com/rohankanojia-forks/web-terminal-operator
Once project is loaded, click on

Run Task> select task:devfile, you would see these options: