Skip to content

Conversation

@rohanKanojia
Copy link
Contributor

@rohanKanojia rohanKanojia commented Jun 20, 2025

What does this PR do?

Update: No need to add additional secrets, There are secrets already added in this repository that can be reused in Devtools image push workflow
In order to make GitHub action for building and pushing tooling container image, we need to add these Secrets to GitHub Actions configuration:
- PUSH_PASSWORD : password for pusing to quay.io/wto

It adds a Devfile (plus the tooling container Dockerfile and the GH to build it) that has a couple of commands to:

  1. Build and push WTO controller image
  2. Register CatalogSource and install the operator
  3. Register CatalogSource only
  4. Unregister CatalogSource
  5. Uninstall the Web Terminal Operator

I was facing some issues with make uninstall target, I have made some modifications in Makefile :

  • I couldn't find any CustomResourceDefinition named workspaceroutings.controller.devfile.io , Probably it was renamed but we forgot to update it's reference. I've renamed it to devworkspaceroutings.controller.devfile.io
  • I couldn't find any CustomResourceDefinition named components.controller.devfile.io, I removed step for uninstalling it
  • I couldn't find any ConfigMap devworkspace-controller in openshift-operators namespace, I removed step for uninstalling it
  • I couldn't find any Makefile target named uninstall_v1_2 , I've removed it from README

What issues does this PR fix or reference?

It's a part of #173

Is it tested? How?

Go to Eclipse Che Dashboard and open this project https://github.com/rohankanojia-forks/web-terminal-operator

Once project is loaded, click on Run Task > select task: devfile , you would see these options:
Screenshot_20250620_160149

@openshift-ci
Copy link

openshift-ci bot commented Jun 20, 2025

Hi @rohanKanojia. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

# Contributors:
# Red Hat, Inc. - initial API and implementation
#
FROM quay.io/devfile/universal-developer-image:latest
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use quay.io/devfile/base-developer-image:ubi9-latest instead? Since it is a smaller image that only includes the essentials for Che

@rohanKanojia
Copy link
Contributor Author

rohanKanojia commented Sep 2, 2025

@dkwon17 : I'm sorry for noticing it this late...I just realized that the push secrets for quay.io/wto are already added to this repository.

I can now see that the GitHub Workflow Next Dockerimages is using these secrets to push the WTO image to Quay.

username: ${{ secrets.QUAY_USERNAME }}
password: ${{ secrets.QUAY_PASSWORD }}

I have updated Devtools container build GitHub workflow to use same GitHub secrets QUAY_USERNAME / QUAY_PASSWORD

@dkwon17
Copy link
Collaborator

dkwon17 commented Sep 6, 2025

/retest

.devfile.yaml Outdated
#
# SPDX-License-Identifier: EPL-2.0
#
schemaVersion: 2.2.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
schemaVersion: 2.2.0
schemaVersion: 2.3.0

tags: |
${{ env.PUSH_REGISTRY }}/${{ secrets.QUAY_USERNAME }}/web-terminal-operator-devtools:latest
${{ env.PUSH_REGISTRY }}/${{ secrets.QUAY_USERNAME }}/web-terminal-operator-devtools:sha-${{ steps.git-sha.outputs.sha }}
file: ./build/dockerfiles/devtools.Dockerfile No newline at end of file
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we please add a newline at the end of this file?

@rohanKanojia
Copy link
Contributor Author

/retest

@openshift-ci
Copy link

openshift-ci bot commented Sep 10, 2025

@rohanKanojia: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dkwon17
Copy link
Collaborator

dkwon17 commented Sep 10, 2025

/ok-to-test

@dkwon17
Copy link
Collaborator

dkwon17 commented Sep 10, 2025

/retest

ENV OPM_VERSION="v1.13.1"
RUN curl -sSLO https://github.com/operator-framework/operator-registry/releases/download/${OPM_VERSION}/linux-amd64-opm && \
chmod +x linux-amd64-opm && \
mv linux-amd64-opm /usr/local/bin/opm
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I didn't realize that the base-developer-image doesn't have oc installed.

Could we install it here?

ENV OC_VERSION=4.19
RUN curl -L https://mirror.openshift.com/pub/openshift-v4/x86_64/clients/ocp/stable-${OC_VERSION}/openshift-client-linux.tar.gz; | \
    tar -C /usr/local/bin -xz --no-same-owner && \
    chmod +x /usr/local/bin/oc

@rohanKanojia rohanKanojia force-pushed the pr/issue173 branch 4 times, most recently from 8106955 to ef0ba61 Compare September 18, 2025 17:21
@dkwon17 dkwon17 merged commit f96ab5f into redhat-developer:main Sep 18, 2025
5 checks passed
@rohanKanojia rohanKanojia deleted the pr/issue173 branch September 19, 2025 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants