Skip to content

Conversation

@rohanKanojia
Copy link
Contributor

@rohanKanojia rohanKanojia commented Sep 19, 2025

What does this PR do?

Not 100% sure why but after merging devtools build workflow failed with this error https://github.com/redhat-developer/web-terminal-operator/actions/runs/17839881221/job/50726360525:

ERROR: failed to build: invalid tag "quay.io/***/web-terminal-operator-devtools:latest": invalid reference format

I suspect there is some unwanted character in it's value (possibly quotes), as same workflow is working on my fork with my username and password https://github.com/rohankanojia-forks/web-terminal-operator/actions/runs/17836441014

Replaced the use of ${{ secrets.QUAY_USERNAME }} in Docker image tags with a
hardcoded wto namespace to ensure valid and predictable image references.

In other github action workflow too it's hardcoded like this:

file: ./build/dockerfiles/controller.Dockerfile
push: true
tags: quay.io/wto/web-terminal-operator:next

What issues does this PR fix or reference?

It tries to fix failed GitHub action execution https://github.com/redhat-developer/web-terminal-operator/actions/runs/17839881221/job/50726360525

Is it tested? How?

@openshift-ci
Copy link

openshift-ci bot commented Sep 19, 2025

Hi @rohanKanojia. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dkwon17
Copy link
Collaborator

dkwon17 commented Sep 19, 2025

/ok-to-test

@dkwon17 dkwon17 merged commit 51f40a9 into redhat-developer:main Sep 19, 2025
5 checks passed
@rohanKanojia rohanKanojia deleted the pr/fix-devtools-build-workflow branch September 19, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants