REDIS_PASSWORD[_FILE] env and empy password warning #492
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimental proof of concept support for setting password via env
Description
This is proof of concept implementation of env vars for setting password and showing a warning if empty password is detected.
REDIS_PASSWORDorREDIS_PASSWORD_FILEvariables.While it's possible to set password using command line args or configuration files, setting it using env vars is a common and well-known pattern.
--includewith temporary config snippet if possible to avoid displaying password in process listFallback to
--requirepassif tmp is not writeable or when starting sentinel (it doesn't support include arg)Open questions
redis-cli(and other clients) to use passwords from env or filedebian/docker-entrypoint.sh(a lot of important stuff and edge cases)--include)Related issues
#355
#46
#268