fix broken initialization of PolarizedQProbe #344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkienzle
reviewed
Nov 13, 2025
refl1d/probe/probe.py
Outdated
|
|
||
| def _calculate_union(self): | ||
| theta_offsets = [x.theta_offset.value for x in self.xs if x is not None] | ||
| theta_offsets = [x.theta_offset.value for x in self.xs if x is not None and hasattr(x, "theta_offset")] |
Member
There was a problem hiding this comment.
The measurement union function uses both Q (hence the dependence on theta_offset) and also dQ, therefore sample_broadening should also be part of the key.
Rather than assuming these properties exist and that they are the only properties that affect the measurement union, we could be delegating to the underlying class, with something like a xs._QdQ_key() method. This will matter more when we have full support for ProbeSet as polarized cross sections.
Member
Author
There was a problem hiding this comment.
That's a good catch on the sample_broadening dependency... this optimization (_calculate_union) is pretty useful in reducing calculation time but it adds a lot of complexity!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently PolarizedQProbe cannot initialize properly, because of changes made to the oversampling logic in #310 I think.
This PR fixes the initialization.