Skip to content

Revert "reflex-dom-core: disable tests to fix determinism" #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
parenthetical wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Revert "reflex-dom-core: disable tests to fix determinism" #815

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d8c5c1
Revert "reflex-dom-core: disable tests to fix determinism"
parenthetical Feb 7, 2023
d8b0966
Merge branch 'develop' into re-enable-reflex-dom-core-tests
ali-abrar May 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions haskell-overlays/reflex-packages/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ in
reflex-todomvc = self.callPackage self._dep.reflex-todomvc {};
reflex-aeson-orphans = self.callCabal2nix "reflex-aeson-orphans" self._dep.reflex-aeson-orphans {};

# The tests for reflex-dom-core are not deterministic, disable them, and run them manually
reflex-dom-core = let
inherit (self) ghc;
noGcTest = stdenv.hostPlatform.system != "x86_64-linux"
Expand All @@ -60,13 +59,11 @@ in
reflexOptimizerFlag
useTemplateHaskellFlag
(lib.optional enableLibraryProfiling "-fprofile-reflex")
[ "-f-hydration-tests" ]
[ "-f-gc-tests" ]
])) {})
(drv: {
# TODO: Get hlint working for cross-compilation
#doCheck = stdenv.hostPlatform == stdenv.buildPlatform && !(ghc.isGhcjs or false);
doCheck = false;
doCheck = stdenv.hostPlatform == stdenv.buildPlatform && !(ghc.isGhcjs or false);

# The headless browser run as part of the tests will exit without this
preBuild = (drv.preBuild or "") + ''
export HOME="$PWD"
Expand Down