Skip to content

Conversation

@dklein-pik
Copy link
Contributor

Purpose of this PR

Please explain your PR here.

Type of change

Indicate the items relevant for your PR by replacing ◻️ with ☑️.
Do not delete any lines. This makes it easier to understand which areas are affected by your changes and which are not.

Parts concerned

  • ◻️ GAMS Code
  • ◻️ R-scripts
  • ◻️ Documentation (GAMS incode documentation, comments, tutorials)
  • ◻️ Input data / CES parameters
  • ◻️ Tests, CI/CD (continuous integration/deployment)
  • ◻️ Configuration (switches in main.gms, default.cfg, and scenario_config*.csv files)
  • ◻️ Other (please give a description)

Impact

  • ◻️ Bug fix
  • ◻️ Refactoring
  • ◻️ New feature
  • ◻️ Change of parameter values or input data (including CES parameters)
  • ◻️ Minor change (default scenarios show only small differences)
  • ◻️ Fundamental change of results of default scenarios

Checklist

Do not delete any line. Leave unfinished elements unchecked so others know how far along you are.
In the end all checkboxes must be ticked before you can merge
.

  • I executed the automated model tests (make test) after my final commit and all tests pass (FAIL 0)
  • I adjusted the reporting in remind2 if and where it was needed
  • I adjusted the madrat packages (mrremind and other packages involved) for input data generation if and where it was needed
  • My code follows the coding etiquette
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • I updated the CHANGELOG.md correctly (added, changed, fixed, removed, input data/calibration)

Further information (optional)

  • Runs with these changes are here:
  • Comparison of results (what changes by this PR?):

dklein-pik added 30 commits July 3, 2025 15:12
Add new realization 'magpie' to module '30_biomass' copying 'magpie_40' and renaming everything.
Any changes needed for the new coupling that are module-related (i.e. not in the core) will be done in the new module.
- updating biomass prices and biomass demand
- calculating shift factors for supply curves
Introduce new preliminary switch 'cm_MAgPIE_Nash' to activate biomass coupling while still using the old emissions
… it from a csv file (CSVread), since CSVread filled up the memory when it was called in the solve loop, leading to out of memory errors.

Added R script that writes the MAgPIE data into a gdx.
Add mapping from MAgPIE variables to REMIND parameters.
- core/preloop.gms -> core/presolve.gms
- 47_regipol/regiCarbonPrice/datainput.gms -> 47_regipol/regiCarbonPrice/presolve.gms
…f MAgPIE iterations sm_magpieIter to trigger the import of magpieData.gdx. Use coupling switch cm_MAgPIE_Nash only to activate the MAgPIE run itself.
Introduce decision and switch when to run MAgPIE
Load MAgPIE data only after MAgPIE has run at least once, otherwise use input data.
Set some switches only after MAgPIE has run at least one (macSwitch, n2obio).
At the end of the run add content of runtime.log to runstatistics.rda.
Remove 'marker' column from GAMS output to runtime.log
Enable processing of multiple gdx files: either to create an individual pdf per run or to plot iterations of mutliple runs into one pdf if runs have been continured
@dklein-pik dklein-pik merged commit af089a4 into remindmodel:develop Dec 5, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant