chore(poc): use host preflight manager mock example #3174
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is a PoC whose aim is to show how we can reduce the maintenance burden of mocks in our codebase. We used as an example the host preflight manager mock and introduced 2 key components:
With this utility struct we can then, within each method of our mock, determine if we have registered calls we want to use or fallback to default stubs.
Drawbacks of the approach
m.On("RunHOSTAPreflights", ...)) can become hard to debug because we'll still get a response (albeit if we run the mock assertions at the end of the test we should get an error the registered method wasn't called).Which issue(s) this PR fixes:
Does this PR require a test?
Does this PR require a release note?
Does this PR require documentation?