feat: add outdated tool version warnings to linter #649
+762
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bishibop
force-pushed
the
feat/add-kots-linter
branch
from
ccddeb1 to
973cbfe
Compare
Bishibop
changed the base branch from
feat/add-kots-linter
to
feat/embedded-cluster-and-kots-linter-integrations
Changes embedded-cluster linter version resolution to extract the version from the manifest's spec.version field instead of from the .replicated config file. This ensures the linter binary matches the runtime version being validated. Changes: - Add ExtractECVersion() to extract spec.version from EC Config manifest - Handle multi-document YAML and templated files with fallback strategy - Update discovery logic to extract and store EC version - Remove tools.embedded-cluster from config-based resolution - Add warning when tools.embedded-cluster is in config (now ignored) - Update metadata with correct version after extraction - Add 9 comprehensive unit tests for version extraction - Update documentation to clarify version source The linter will use "latest" as fallback if version extraction fails, allowing the EC linter itself to report missing version errors.
Adds automatic version checking before linting starts to warn users when
their configured tool versions are outdated compared to recommended versions
from the Replicated API.
Changes:
- Add FetchRecommendedVersions() to query replicated.app/ping (5s timeout)
- Add CompareVersions() to compare versions using semver (major/minor only)
- Add checkToolVersions() to CLI that checks all enabled linters
- Add ToolVersionWarnings field to JSON output
- Display warnings before linting starts (both table and JSON formats)
- Add comprehensive unit tests for version comparison logic
- Update documentation with tool version check behavior
Behavior:
- Only checks enabled linters with explicitly pinned versions (not "latest")
- Only warns for minor/major version differences (patch = silent)
- Makes single API call for all tools (efficient, no caching needed)
- EC version compared from manifest spec.version (not config)
- Non-blocking: warnings are informational (don't fail linting)
- Graceful degradation if API unavailable
Example warning:
Warning: helm version 3.14.0 is below recommended version 3.15.2.
Update your .replicated config:
tools:
helm: '3.15.2'
Add comprehensive integration tests for the outdated tool version warnings feature to validate end-to-end behavior: - TestLint_VersionWarningsDisplay: Verifies warnings appear in output - TestLint_VersionWarningsOnlyForEnabledLinters: Verifies disabled linters don't warn - TestLint_VersionWarningsSkipLatest: Verifies "latest" doesn't trigger warnings - TestLint_VersionWarningsInJSON: Verifies JSON output structure - TestLint_VersionWarningsECUsesManifest: Verifies EC version from manifest Remove redundant unit tests for FetchRecommendedVersions() that were making real API calls and provided no value beyond what the integration tests cover. The actual business logic (CompareVersions) already has excellent unit test coverage with 13 tests covering all edge cases. Test coverage: - 13 unit tests for version comparison logic (fast, isolated) - 5 integration tests for full lint command flow (validates user behavior)
Remove 5 integration tests that made real API calls to replicated.app/ping. These tests added network dependency and potential flakiness to CI. The core version comparison logic is already comprehensively tested by 13 unit tests in pkg/tools/version_info_test.go covering all edge cases including major/minor/patch differences, version normalization, invalid versions, and EC format handling. Tests removed: - TestLint_VersionWarningsDisplay - TestLint_VersionWarningsOnlyForEnabledLinters - TestLint_VersionWarningsSkipLatest - TestLint_VersionWarningsInJSON - TestLint_VersionWarningsECUsesManifest
Bishibop
force-pushed
the
feat/handle-outdated-tool-versions
branch
from
c3b7a99 to
c44191c
Compare
NoaheCampbell
approved these changes
Nov 12, 2025
Bishibop
merged commit 11b7d40
into
feat/embedded-cluster-and-kots-linter-integrations
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds version warnings to the linter that check if configured tool versions are outdated compared to recommended versions.
Changes
Steps to test:
Test that warnings appear when using an old version.
cd examplesEdit examples/.replicated.yaml:
Run linter with v2 enabled
Expected output:
Warning: helm version 3.12.0 is below recommended version 3.15.x.
Update your .replicated config:
tools:
helm: '3.15.x'