Add advanced !packet command #20
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This command supports the following 'placeholders': - lNNN for writing int64 - iNNN for writing int32 - sNNN for writing int16 - bNNN for writing int8 - "text" for writing a string Also i fixed/expanded the atoli() function. It now acts more like atoi, where it has to remove whitespaces (using isspace) first, then check for the plus/minus sign, and after that finally parse the numbers. After that, make the value negative, of course.
…last bit, thus making it non-negative values.
LazyBui
approved these changes
Nov 26, 2016
| chat_handler_functions::show_info(player, "Number '" + value_string + "' is not between 0 and " + lexical_cast<string>(UINT16_MAX)); | ||
| return chat_result::handled_display; | ||
| } | ||
| packet.add<int16_t>(static_cast<int16_t>(value)); |
Collaborator
There was a problem hiding this comment.
Is intentional that you don't cast to uint16_t here? Same for these other casts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This command supports the following 'placeholders':
lNNNfor writing int64iNNNfor writing uint32sNNNfor writing uint16bNNNfor writing uint8"text"for writing a stringAlso i fixed/expanded the atoli() function. It now acts more like atoi, where it has to remove whitespaces (using isspace) first, then check for the plus/minus sign, and after that finally parse the numbers. After that, make the value negative, of course.