gen-kdump-sysconfig.sh: put shared values into the _common array member

[coiby]

Some values are shared by all architectures. For readability and maintainability, extract them into a new array member _common.

Note I believe kfence.sample_interval=0 shall be shared by unknown architecture so I also put it into the _common field of KDUMP_COMMANDLINE_APPEND.

[gemini-code-assist]

Summary of Changes

Hello @coiby, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the gen-kdump-sysconfig.sh script to improve its maintainability and readability. By extracting common kernel command-line parameters into a new _common field within associative arrays, the script now centralizes values shared across multiple architectures. This change simplifies the management of kdump configuration, making it easier to update or add parameters without duplicating them across various architecture-specific entries.

Highlights

• Refactoring Shared Kernel Parameters: The gen-kdump-sysconfig.sh script has been refactored to introduce a _common field within the KDUMP_COMMANDLINE_REMOVE and KDUMP_COMMANDLINE_APPEND associative arrays. This centralizes kernel parameters that are shared across all architectures, improving maintainability.
• New set_value Function: A new shell function, set_value, has been implemented. This function dynamically combines parameters from the _common field with architecture-specific or default values, streamlining the process of constructing kernel command-line arguments.
• Consolidated kfence.sample_interval: The kfence.sample_interval=0 parameter has been moved to the _common field within KDUMP_COMMANDLINE_APPEND, ensuring its consistent application across all architectures without duplication.
• Shellcheck Directives Added: Comments disabling shellcheck warning SC2034 have been added to prevent false positives related to the use of associative arrays, ensuring cleaner static analysis results.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors gen-kdump-sysconfig.sh to improve readability and maintainability by extracting shared configuration values into a common field. The change is well-motivated and cleanly implemented. I have two suggestions: one to improve compatibility with older bash versions by avoiding local -n, and another to restore the newline at the end of the file, which is a standard convention.

[licliu]

Thanks @coiby! This patch looks good to me.