-
Notifications
You must be signed in to change notification settings - Fork 127
Run prettier on all Explorer files
#1267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| "txn_sec_description": null, | ||
| "load_fee_description": null, | ||
| "nUnl_description": null, | ||
| "volume": null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These were all duplicates
| @@ -1,8 +1,8 @@ | |||
| version: 2 | |||
| updates: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening the PR! Do you know how to set up an "apply prettier on file save" rule or formatter? Doing it in batch later makes git blame less useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have it in my IDE and am not quite sure how to share that. That's also the purpose of the pre-commit setting though - everyone can install it via pre-commit install and it'll automatically run when you try to git commit.
You can also remove this specific git hash from the git blame history.
10c7bee to
2617394
Compare
High Level Overview of Change
This PR runs
prettieron all Explorer files (it seems that it wasn't properly run on non-JS/TS files before). It also configures CI and CLI scripts to checkprettieras well, and sets up some basic pre-commit settings.This PR does not make any code changes, only linting changes.
Context of Change
General repo cleanup
Type of Change
Codebase Modernization
N/A
Before / After
Test Plan
Works locally. CI passes.