Skip to content

Conversation

@mvadari
Copy link
Collaborator

@mvadari mvadari commented Dec 5, 2025

High Level Overview of Change

This PR runs prettier on all Explorer files (it seems that it wasn't properly run on non-JS/TS files before). It also configures CI and CLI scripts to check prettier as well, and sets up some basic pre-commit settings.

This PR does not make any code changes, only linting changes.

Context of Change

General repo cleanup

Type of Change

  • Chore

Codebase Modernization

N/A

Before / After

Test Plan

Works locally. CI passes.

"txn_sec_description": null,
"load_fee_description": null,
"nUnl_description": null,
"volume": null,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were all duplicates

@@ -1,8 +1,8 @@
version: 2
updates:
Copy link
Contributor

@kuan121 kuan121 Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening the PR! Do you know how to set up an "apply prettier on file save" rule or formatter? Doing it in batch later makes git blame less useful.

Copy link
Collaborator Author

@mvadari mvadari Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have it in my IDE and am not quite sure how to share that. That's also the purpose of the pre-commit setting though - everyone can install it via pre-commit install and it'll automatically run when you try to git commit.

You can also remove this specific git hash from the git blame history.

@mvadari mvadari requested a review from kuan121 December 10, 2025 01:07
kuan121
kuan121 previously approved these changes Dec 13, 2025
@Patel-Raj11 Patel-Raj11 merged commit 6bbd765 into staging Jan 5, 2026
5 checks passed
@Patel-Raj11 Patel-Raj11 deleted the prettier-css branch January 5, 2026 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants