fix(query): trim input while reading #877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Fixing CI failures in #878 -- will merge master in once that PR is merged. |
rtadepalli
force-pushed
the
trim-query-before-processing
branch
from
d60c14d to
6803f7e
Compare
skyzh
approved these changes
Jun 1, 2025
Signed-off-by: Ramasai Tadepalli <[email protected]>
rtadepalli
force-pushed
the
trim-query-before-processing
branch
from
6803f7e to
05431e9
Compare
Contributor
Author
|
Thank you for the approval @skyzh, could you please merge this as well. |
skyzh
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now if the query is
create table employees (firstname varchar);(with some spaces at the end) the prompt is going to be?. The query will only be processed if another semicolon is added. Trim the response such that there is no need to add a second semicolon.