apiendpoint.Mount: take options struct including middleware stack #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgentry
force-pushed
the
bg-mount-opts
branch
3 times, most recently
from
6040683 to
58b9082
Compare
brandur
approved these changes
Mar 15, 2025
Contributor
brandur
left a comment
brandur
left a comment
There was a problem hiding this comment.
Cool. Yeah seems like a relatively easy way to get this solved without something a lot more elaborate (like a smarter router). That logger parameter was going to have to become an Opts struct as some point anyway.
Maybe add a test case for this option to make sure it works?
Allow for an endpoint-specific middleware stack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for an endpoint-specific middleware stack. I took a stab at this because I need it, but I'm totally good with reworking it any way you want.