Add Phaser-based isometric fleet client and template #40
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| const players: PlayerState[] = Array.from(this.players.values()).map((entity) => ({ | ||
| ...entity.state, | ||
| tileX: entity.state.tileX, | ||
| tileY: entity.state.tileY | ||
| })); | ||
| const ships: ShipState[] = Array.from(this.ships.values()).map((ship) => ({ | ||
| ...ship.state, | ||
| passengers: new Set(ship.state.passengers) | ||
| })); |
There was a problem hiding this comment.
Snapshots broadcast to other clients include ShipState.passengers as a Set. When sendSnapshot stringifies the snapshot, each Set serializes to {}. Receivers apply that payload back into ShipEntity, so ship.state.passengers becomes a plain object; the next time the local scene executes ship.state.passengers.add(...) (e.g. when a player boards a ship) a TypeError is thrown and passenger membership stops updating. Converting the set to an array before sending and rebuilding a Set when reading would keep snapshots round‑trippable and avoid runtime crashes whenever a snapshot arrives.
Useful? React with 👍 / 👎.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68ebba5604b08325a113d63b1e0b6a39