feat: add isometric fleet template and world simulation #42
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| public boardShip(playerId: EntityId, shipId: EntityId, deckPosition?: Vector2): void { | ||
| const player = this.players.get(playerId); | ||
| const ship = this.ships.get(shipId); | ||
| if (!player || !ship) { | ||
| return; | ||
| } | ||
|
|
||
| const relativePosition = deckPosition ?? subtractVectors(player.position, ship.position); | ||
| ship.boardedPlayers[playerId] = relativePosition; | ||
| player.boardedShipId = shipId; | ||
| player.relativePosition = relativePosition; | ||
| player.position = addVectors(ship.position, relativePosition); | ||
| this.emit('player-moved', { type: 'player-moved', player }); | ||
| } |
There was a problem hiding this comment.
When boardShip is called for a player who is already aboard another vessel, the code assigns the new boardedShipId and updates the new ship’s boardedPlayers map but never removes the player from the old ship’s boardedPlayers. The previous ship will continue to treat the player as boarded and, in tick, will keep updating their position and velocity even after they have moved to another ship. With two ships moving simultaneously the player’s state will be overwritten every frame, producing jitter and inconsistent world snapshots. Clear the player from the previous ship before assigning the new ship.
Useful? React with 👍 / 👎.
| }); | ||
|
|
||
| this.emit('ship-moved', { type: 'ship-moved', ship }); | ||
| }); |
There was a problem hiding this comment.
Bug: Ship Movement Overwrites Player Intents
During tick, boarded players' individual movement intents are processed, but their position and velocity are then immediately overwritten by the ship's movement. This causes personal movement to be ignored and results in an incorrect velocity.
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68ebba6b8f7c8325a0a5ba978029e685