Skip to content

localhost option in config #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

localhost option in config #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ module.exports = {
outgoingWebhookServer: {
port: 666,
Copy link
Owner

@rknLA rknLA May 28, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, did you want to change this to Number(process.env.PORT || 666)?

Copy link
Author

@forresto forresto May 28, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that might be too specific to Heroku.

Copy link
Owner

@rknLA rknLA May 28, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

process.env.PORT seems generic enough to me to leave in. Based on #10, though, 666 is probably not the right number to keep in.

domain: 'your.webhook.server.com',
hookPath: '/irc-echo'
hookPath: '/irc-echo',
localhost: 'localhost'
Copy link
Owner

@rknLA rknLA May 28, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still meditating on this object key a bit.. it seems weird to call it localhost, but it's also telling that the value should be...

},
echoChannel: '#irc-echo',
botName: 'IRCBot',
Expand Down
2 changes: 1 addition & 1 deletion lib/slack.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ module.exports = {

/* Slack Outgoing Web Hook listening server */

var server = new Hapi.Server('localhost', config.slack.outgoingWebhookServer.port, {
var server = new Hapi.Server(config.slack.outgoingWebhookServer.localhost, config.slack.outgoingWebhookServer.port, {
location: config.slack.outgoingWebhookServer.domain,
});

Expand Down