Skip to content

update base.md #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
YuriGii wants to merge 3 commits into
base: master
Choose a base branch
from
Open

update base.md #48

YuriGii wants to merge 3 commits into from

Conversation

@YuriGii
Copy link

@YuriGii YuriGii commented Mar 27, 2022 •
edited
Loading

  • removed thumb field from base.md for parts item
  • added zName field to properties metadata spec for base

@YuriGii YuriGii self-assigned this Mar 27, 2022
@YuriGii YuriGii requested a review from Yuripetusko March 27, 2022 18:24
@Yuripetusko
Copy link
Contributor

Yuripetusko commented Mar 27, 2022

Ehm no. This is not following metadata spec

Yuripetusko
Yuripetusko reviewed Mar 27, 2022
View reviewed changes
standards/rmrk2.0.0/entities/metadata.md
"type": "int",
"value": 2
"value": 2,
"name": "string"
Copy link
Contributor

@Yuripetusko Yuripetusko Mar 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Yuripetusko Yuripetusko Yuripetusko left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@YuriGii YuriGii

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@YuriGii @Yuripetusko