Skip to content

Conversation

@forsberg
Copy link

Description

An attempt to fix #672. I'm not all that experienced in using mypy/typing in Python, so there may be better ways.

#type: ignore is also an option, I guess.

@codecov-io
Copy link

codecov-io commented Oct 20, 2020

Codecov Report

Merging #673 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #673   +/-   ##
=======================================
  Coverage   98.32%   98.32%           
=======================================
  Files          99       99           
  Lines       10193    10195    +2     
  Branches     1139     1139           
=======================================
+ Hits        10022    10024    +2     
  Misses        138      138           
  Partials       33       33           
Impacted Files Coverage Δ
faust/models/fields.py 97.26% <100.00%> (+<0.01%) ⬆️
faust/models/record.py 96.39% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01b4c0a...12626a6. Read the comment docs.

@camerondavison
Copy link

any progress on getting this pushed through? it could be nice to get venusian upgraded

@CLAassistant
Copy link

CLAassistant commented Sep 21, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mypy version 0.790 complains on faust/models/records.py on master causing build failures

4 participants