-
Notifications
You must be signed in to change notification settings - Fork 74
Fix configuration files for remapper in iCubGenova11 #770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix configuration files for remapper in iCubGenova11 #770
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
|
Hi @MSECode The CI (xml) still fails for iCubGenova11. |
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly updates the configuration files to use rawValuesPublisherRemapper for iCubGenova11, and adjusts the CI checks accordingly. The changes are logical and address the goal of the PR. I have a few suggestions to improve the code quality, mainly related to consistency and maintainability. I've pointed out some missing newlines at the end of files, a misleading log message, and an opportunity to reduce code duplication. Overall, good work on fixing the configuration and CI.
|
So, in order to fix the CI, we needed to update the
Thus, the main issue that made the CI failing was the fact that for |
|
Thanks for the extensive explanation, @MSECode 🚀 |
This PR fixes the configuration files for iCubGenova11 in relation to the
rawValuesPublisherRemapper. This should fix the CI as well