Draft: Refactor bot to use a repo-specific config system #357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…them directly to use in bot
…ations, prepare for removal later
…nstallation.id and without it
…AT, remove GITHUB_ACCESS_TOKEN
…fig, fallback to the original hardcoded for backward compability
lykimq
force-pushed
the
quyen@abstract_coq_2
branch
from
5ef75cd to
f7cb270
Compare
lykimq
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on the #358
The goal of this PR is to replace hardcoded values of
rocqwith configurable settings incoqbot-config.tomland have a backward compatibility. There are also added Alcotest for it as well.What new:
src/config/repo_config.ml: this is for parsing and managing repo-specific settingscoqbot-config.tomladded[repositories.*]to config per-repo settingscoqbot-config.toml: CI, labels, jobs, documentation paths, GitLab mappings, GitHub installation ID, minimizer URLsrcand maintain fallback to original hardcoded values when repo config is not presentrepo_config_test.ml, property-based teststest-config.ml(for integer), error case tests for invalid configurations, integration tests for config lookup and validation