Skip to content

Conversation

@SkySkimmer SkySkimmer added the request: full CI Use this label when you want your next push to trigger a full CI. label Jan 6, 2025
@coqbot-app coqbot-app bot removed the request: full CI Use this label when you want your next push to trigger a full CI. label Jan 6, 2025
@coqbot-app
Copy link
Contributor

coqbot-app bot commented Jan 6, 2025

🔴 CI failure at commit 02cd67a without any failure in the test-suite

✔️ Corresponding job for the base commit 253e9af succeeded

❔ Ask me to try to extract a minimal test case that can be added to the test-suite

🏃 @coqbot ci minimize will minimize the following target: ci-riscv_coq
  • You can also pass me a specific list of targets to minimize as arguments.

@SkySkimmer SkySkimmer added needs: fixing The proposed code change is broken. needs: overlay This is breaking external developments we track in CI. labels Jan 6, 2025
@github-actions github-actions bot added the needs: rebase Should be rebased on the latest master to solve conflicts or have a newer CI run. label Jan 7, 2025
@SkySkimmer
Copy link
Contributor Author

Minimized error from riscv

Unset Universe Minimization ToSet.
Record R (T:Type) := mk { x : nat -> T }.

@SkySkimmer SkySkimmer added kind: redesign The same functionality is being re-implemented in a different way. kind: enhancement Enhancement to an existing user-facing feature, tactic, etc. part: universes The universe system. part: inductives Inductive types, fixpoints, etc. labels Jan 7, 2025
@SkySkimmer
Copy link
Contributor Author

Minimized error from riscv

The higher layers see Type@{q|u} -> Type@{q|u}, but the kernel is not actually sort polymorphic so it sees the constructor argument (nat -> T) : Type@{max(Set,u)} and wants Type@{u} -> Type@{max(Set,u)}

@SkySkimmer
Copy link
Contributor Author

"is pseudo sort poly" should probably be an annotation for each template universe instead of being global to the inductive, for strange types like

Inductive dumb' (A:Type) (b:bool) (B : Type) := cons' : A -> (b = true -> dumb' A false nat) -> dumb' A b B.

(the univ of A is pseudo sort poly, the univ of B is not but is not used in the conclusion)

@SkySkimmer SkySkimmer force-pushed the cominductive-lbound branch from 02cd67a to 8fd19de Compare January 7, 2025 12:28
@coqbot-app coqbot-app bot added needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. and removed needs: rebase Should be rebased on the latest master to solve conflicts or have a newer CI run. labels Jan 7, 2025
@SkySkimmer
Copy link
Contributor Author

Minimized error from riscv

The higher layers see Type@{q|u} -> Type@{q|u}, but the kernel is not actually sort polymorphic so it sees the constructor argument (nat -> T) : Type@{max(Set,u)} and wants Type@{u} -> Type@{max(Set,u)}

Trying to work around this seems difficult, so I guess I'll try to make the kernel more sort polymorphic in this PR.

@SkySkimmer SkySkimmer force-pushed the cominductive-lbound branch from 8fd19de to 03a74e7 Compare January 8, 2025 12:12
@SkySkimmer SkySkimmer added the request: full CI Use this label when you want your next push to trigger a full CI. label Jan 17, 2025
@coqbot-app coqbot-app bot removed request: full CI Use this label when you want your next push to trigger a full CI. needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. labels Jan 17, 2025
@SkySkimmer SkySkimmer removed the needs: fixing The proposed code change is broken. label Jan 17, 2025
SkySkimmer added a commit to SkySkimmer/coq-elpi that referenced this pull request Jan 17, 2025
SkySkimmer added a commit to SkySkimmer/coq-lsp that referenced this pull request Jan 17, 2025
SkySkimmer added a commit to SkySkimmer/paramcoq that referenced this pull request Jan 17, 2025
@SkySkimmer SkySkimmer added request: full CI Use this label when you want your next push to trigger a full CI. and removed needs: overlay This is breaking external developments we track in CI. labels Jan 17, 2025
@coqbot-app coqbot-app bot removed the request: full CI Use this label when you want your next push to trigger a full CI. label Jan 17, 2025
@coqbot-app coqbot-app bot removed request: full CI Use this label when you want your next push to trigger a full CI. needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. labels Jan 23, 2025
@SkySkimmer SkySkimmer added the request: full CI Use this label when you want your next push to trigger a full CI. label Jan 23, 2025
@coqbot-app coqbot-app bot removed the request: full CI Use this label when you want your next push to trigger a full CI. label Jan 23, 2025
SkySkimmer added a commit to SkySkimmer/coq-elpi that referenced this pull request Jan 23, 2025
@SkySkimmer SkySkimmer added the request: full CI Use this label when you want your next push to trigger a full CI. label Jan 23, 2025
@coqbot-app coqbot-app bot removed the request: full CI Use this label when you want your next push to trigger a full CI. label Jan 23, 2025
@SkySkimmer SkySkimmer added needs: fixing The proposed code change is broken. request: full CI Use this label when you want your next push to trigger a full CI. and removed request: full CI Use this label when you want your next push to trigger a full CI. labels Jan 23, 2025
@SkySkimmer SkySkimmer added request: full CI Use this label when you want your next push to trigger a full CI. and removed needs: fixing The proposed code change is broken. labels Jan 23, 2025
@coqbot-app coqbot-app bot removed the request: full CI Use this label when you want your next push to trigger a full CI. label Jan 23, 2025
@SkySkimmer SkySkimmer removed the needs: overlay This is breaking external developments we track in CI. label Jan 23, 2025
@SkySkimmer SkySkimmer marked this pull request as ready for review January 23, 2025 19:00
@ppedrot ppedrot self-assigned this Jan 27, 2025
@ppedrot ppedrot added this to the 9.1+rc1 milestone Jan 27, 2025
@ppedrot
Copy link
Member

ppedrot commented Jan 27, 2025

@coqbot merge now

@coqbot-app coqbot-app bot merged commit 2faba2a into rocq-prover:master Jan 27, 2025
7 checks passed
@coqbot-app
Copy link
Contributor

coqbot-app bot commented Jan 27, 2025

@ppedrot: Please take care of the following overlays:

  • 19985-SkySkimmer-cominductive-lbound.sh

SkySkimmer added a commit to rocq-community/rocq-lean-import that referenced this pull request Jan 27, 2025
@SkySkimmer SkySkimmer deleted the cominductive-lbound branch January 27, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind: enhancement Enhancement to an existing user-facing feature, tactic, etc. kind: redesign The same functionality is being re-implemented in a different way. part: inductives Inductive types, fixpoints, etc. part: universes The universe system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants