Hack debug option for name printing #21305
Draft
+10
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an option `Printing All Names` off by default which does 2 things when on: - stop printing `_` for binders of unused variable (eg `forall H:nat, nat` isn't printed as `forall _:nat, nat`) - print the original name (before renaming to avoid shadowing) in comments so eg `forall x x : Prop, x` prints `forall x (* x *) x0 (* x *) : Prop, x0 (* x *)` If we ever want to merge the second part should be implemented in a less hacky way, and maybe separate the 2 parts to use separate options.
coqbot-app
bot
added
the
needs: full CI
Contributor
|
I once again had issues with that, and I do think it would be a simple but useful feature to have for people that do meta-programming |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an option
Printing All Namesoff by default which does 2 things when on:stop printing
_for binders of unused variable (egforall H:nat, natisn't printed asforall _:nat, nat)print the original name (before renaming to avoid shadowing) in comments so eg
forall x x : Prop, xprintsforall x (* x *) x0 (* x *) : Prop, x0 (* x *)If we ever want to merge the second part should be implemented in a less hacky way, and maybe separate the 2 parts to use separate options.