refactor(ptz): Migrate from onvif-zeep to onvif-python library

[kaburagisec]

• Replace deprecated onvif-zeep with new onvif-python

• Remove ONVIFService import and update type annotations

• All PTZ functionality remains unchanged

• Uses the built-in wsdl file that is included in the onvif-python library

• Benefits: better device discovery, CLI support, improved error handling

• Related issues:

  • Telegram and ptz error #997
  • [FEATURE] PTZ controls #449

[netlify]

✅ Deploy Preview for viseron canceled.

Name	Link
🔨 Latest commit	88d8d5d
🔍 Latest deploy log	https://app.netlify.com/projects/viseron/deploys/6901cf52f6b6470008896111

[roflcoopter]

Thanks! I see that python-onvif is pretty new. Is it used by any larger projects today?

[kaburagisec]

Thank you for your feedback.

I use it for corporate projects, and it's worth noting that I also created onvif-python (https://github.com/nirsimetri/onvif-python). This library uses a built-in WSDL, which is more accurate because it's sourced directly from https://github.com/onvif/specs (the official ONVIF WSDL specification).

In this PR, I also made a change to remove the _get_wsdl_dir function, as the onvif-python library already automatically resolves it. I've also tested it on Windows, Linux, and macOS without any issues.

It's also worth noting that the onvif-python implementation is almost identical to onvif-zeep, as they both use the zeep (https://github.com/mvantellingen/python-zeep) library for SOAP communication. However, it has a more modern approach and supports Python 3.9 and above.

If there are any changes I need to include, please let me know and I will fix them. Thank you again.

Note:

• onvif-zeep
  • repo: http://github.com/quatanium/python-onvif
  • pypi: https://pypi.org/project/onvif-zeep
• onvif-python
  • repo: https://github.com/nirsimetri/onvif-python
  • pypi: https://pypi.org/project/onvif-python

[kaburagisec]

Additionally, since Viseron's ONVIF implementation is limited to PTZ services, if the PR is accepted, I'll try to create a new PR with other ONVIF service implementations. Since ONVIF devices have many services that should be used, such as Events, Imaging, and Media, Viseron will be even more powerful.

[roflcoopter]

Thanks for the explanation!

Sounds good. A proper ONVIF component in Viseron has been requested many times but i have never gotten around to it.
I would higly appreciate if you would take the time to implement that. As you say, that could enable Viseron to use the cameras motion detection or AI capabilities to start recordings instead of running it in Viseron.

Please dont hesitate to ask if you have any questions regarding that.

[roflcoopter]

CI is failing on a conflict for the requests package, could you bump the requests version?

[kaburagisec]

Ok I have done the version change.

[kaburagisec]

It looks like the latest CI results are not from my commit error. There it says:

Logging in to Azure DevOps
ERROR: Failed to authenticate using the supplied token.
Downloading libhailort-amd64 version 4.22.0
ERROR: Failed to update Universal Packages tooling. 
TF400813: Resource not available for anonymous access. Client authentication required.

Is there anything I can help?

[roflcoopter]

You are correct, its unrelated to your changes. Something changed in Azure which causes that issue.

Will merge this now, thanks!

[kaburagisec]

Thank you, I'll start implementing the PTZ function on the front end. Because it's incredibly painful to have to use Telegram to control the camera, in most cases, the PTZ should be inside the VMS (Video Management System), not outside it.

But thank you again.

[roflcoopter]

Agreed, having it in the UI would be great!

I dont own any PTZ cameras myself currently so thats why i havent done it myself yet.