Use latest 3.38.5 flutter for the CI and drop Flutter 1.x compat #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR updates the SDK to use Flutter 3.38.5 and removes compatibility code for Flutter 1.x. The changes eliminate conditional source directory selection logic that is no longer needed.
Key Changes:
- Removed Flutter 1.x compatibility logic from Android build configuration
- Updated CI workflows to use Flutter 3.38.5
- Bumped SDK version to 3.38.5
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| rollbar_flutter/android/build.gradle | Removed conditional logic that selected different test source directories based on Flutter version |
| build_tools/SDK_VERSION | Updated SDK version from 3.38.4 to 3.38.5 |
| .github/workflows/ci.yml | Updated Flutter version in CI matrix from 3.29.2 to 3.38.5 for both Android and iOS jobs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Our SDK wouldn't work with the latest versions of 3.38.5 due to a detail we used in older Flutters to attempt branching the build in case the Flutter version was 1.x.
This PR: