Split toolchains for example vs plugin #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- example: AGP 8.11.1 + Gradle 8.14.3, namespace, SDK 35, minSdk 21 - plugin: keep AGP 7.1.2 + Gradle 7.4, drop Flutter 1.x test sources - add jsr305 to satisfy R8 missing javax.annotation.Nullable - CI: run Flutter 3.29/3.38, use JDK 17 for example + JDK 11 for plugin check
matux
changed the title
There was a problem hiding this comment.
Pull request overview
This PR modernizes the Android toolchain configuration by separating build requirements for the example app and the plugin module. The example app is updated to use the latest Android toolchain (AGP 8.11.1, Gradle 8.14.3, compileSdk 35), while the plugin maintains backward compatibility with AGP 7.1.2 and Gradle 7.4. The CI matrix is expanded to test against both Flutter 3.29.2 and 3.38.5, with JDK versions adjusted accordingly (JDK 17 for example builds, JDK 11 for plugin checks).
Key changes:
- Example app upgraded to modern Android toolchain with namespace declaration and updated SDK versions
- Plugin module maintains compatibility toolchain and removes deprecated Flutter 1.x test source branching
- Added jsr305 dependency to resolve R8 annotation issues
Reviewed changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| rollbar_flutter/example/ios/Flutter/ephemeral/flutter_lldbinit | Generated LLDB configuration file for Flutter debugging |
| rollbar_flutter/example/ios/Flutter/ephemeral/flutter_lldb_helper.py | Generated LLDB helper script for handling RX pages during debugging |
| rollbar_flutter/example/android/settings.gradle | Upgrades AGP from 7.1.2 to 8.11.1 for example app |
| rollbar_flutter/example/android/gradle/wrapper/gradle-wrapper.properties | Updates Gradle wrapper from 7.4 to 8.14.3 for example app |
| rollbar_flutter/example/android/app/src/main/AndroidManifest.xml | Removes legacy package attribute (now handled by namespace in build.gradle) |
| rollbar_flutter/example/android/app/build.gradle | Adds namespace, updates SDK versions, and switches to Flutter-provided SDK values |
| rollbar_flutter/android/src/testflutter1/java/com/rollbar/flutter/compatibility/CodecAdapter.java | Removes Flutter 1.x compatibility test code |
| rollbar_flutter/android/gradlew.bat | Updates Gradle wrapper script to newer version |
| rollbar_flutter/android/gradlew | Updates Gradle wrapper script to newer version |
| rollbar_flutter/android/gradle/wrapper/gradle-wrapper.properties | Changes Gradle distribution from 7.4-all to 7.4-bin for plugin module |
| rollbar_flutter/android/build.gradle | Adds jsr305 dependency and removes Flutter 1.x source set branching logic |
| build_tools/SDK_VERSION | Increments version from 3.38.4 to 3.38.5 |
| .github/workflows/ci.yml | Expands Flutter version matrix, updates JDK configuration for different build steps |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
buongarzoni
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modernizes the Android toolchain configuration by separating build requirements for the example app and the plugin module. The example app is updated to use the latest Android toolchain (AGP 8.11.1, Gradle 8.14.3, compileSdk 35), while the plugin maintains backward compatibility with AGP 7.1.2 and Gradle 7.4. The CI matrix is expanded to test against both Flutter 3.29.2 and 3.38.5, with JDK versions adjusted accordingly (JDK 17 for example builds, JDK 11 for plugin checks).