Skip to content

Conversation

@aminya
Copy link

@aminya aminya commented Dec 7, 2021

@aminya aminya marked this pull request as ready for review December 7, 2021 08:22
@aminya aminya force-pushed the setup-cpp branch 2 times, most recently from 5b4e24e to f6fe788 Compare December 7, 2021 08:27
@aminya aminya marked this pull request as draft December 7, 2021 08:29
@aminya aminya force-pushed the setup-cpp branch 2 times, most recently from 6149ae9 to 14b8d44 Compare December 7, 2021 09:16
@aminya

This comment has been minimized.

@aminya aminya force-pushed the setup-cpp branch 3 times, most recently from b0f1211 to b34c634 Compare December 7, 2021 12:50
@aminya aminya marked this pull request as ready for review December 7, 2021 13:35
@rollbear
Copy link
Owner

rollbear commented Dec 7, 2021

Apologies for being a bit silent, but I will get back to you in a couple of days. I much appreciate the work you're doing. Thanks.

@codecov
Copy link

codecov bot commented Dec 7, 2021

Codecov Report

Merging #266 (f083f90) into main (c9c0df9) will decrease coverage by 21.98%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #266       +/-   ##
===========================================
- Coverage   97.75%   75.77%   -21.99%     
===========================================
  Files           1        1               
  Lines         890      875       -15     
===========================================
- Hits          870      663      -207     
- Misses         20      212      +192     
Impacted Files Coverage Δ
include/trompeloeil.hpp 75.77% <0.00%> (-21.99%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rollbear
Copy link
Owner

rollbear commented Dec 7, 2021

On the libc++ build/install-script. It's only there because not all versions have readily available downloads (as .deb packages.) If setup-cpp provides the right libc++ versions already, that step can be removed.

@aminya
Copy link
Author

aminya commented Dec 7, 2021

Apologies for being a bit silent, but I will get back to you in a couple of days. I much appreciate the work you're doing. Thanks.

You're welcome!

On the libc++ build/install-script. It's only there because not all versions have readily available downloads (as .deb packages.) If setup-cpp provides the right libc++ versions already, that step can be removed.

setup-cpp downloads the original llvm releases, which usually include the libcxx. It does not use apt for this. So, I think we can try removing it. If there is a separate installation step required for libcxx, we can add it to setup-cpp

@aminya
Copy link
Author

aminya commented Dec 7, 2021

The libcxx issue is fixed. It required using the correct LLVM_PATH and also passing the CPPFLAGS and LDFLAGS to cmake.

@aminya

This comment has been minimized.

@aminya
Copy link
Author

aminya commented Dec 7, 2021

Yay! Everything is fixed now. 🎉

@aminya
Copy link
Author

aminya commented Dec 10, 2021

The failures are due to missing coverage reports on some versions, which I think is unrelated to this PR. Right?

@rollbear
Copy link
Owner

I'm not so sure that it is unrelated to the PR. If you look at the "Collect Coverage" step for gcc 4.8, it says:

kcov: error while loading shared libraries: libopcodes-2.34-system.so: cannot open shared object file: No such file or directory

Why is that library missing here?

@aminya
Copy link
Author

aminya commented Dec 10, 2021

I updated kcov to v39 because it does not need to be built from the source this way. It might rely on some shared libraries that are missing in the old GCC installer. I need to try install missing packages and see if the issue is fixed.

@rollbear
Copy link
Owner

Sorry for not paying much attention, but the push to finish things before Christmas was a bit intense.

I've looked into the current state, and tried to figure out how to move forward, but I haven't been that successful.

All builds that use ubuntu-18.04 fail because kcov needs binutils-2.34, but the one installed is 2.30. I then tried to use ubuntu-20.04 also for the older compilers, but that failed for completely different reasons. Now C++ standard headers cannot be found, so it looks like libstdc++ and libc++ are not available, or in paths that the compiler cannot find. I had hoped to reach a state where it all builds, but perhaps with some missing functionality, but unfortunately I have failed.

@rollbear
Copy link
Owner

Of course, a different route forward, that may be easier, is to scrap kcov (it's not like I'm married to it) and use normal coverage builds instead. I have to read up on how to use it with the CI codecov-action, but I presume it's a normal enough use to be reasonably straight forward.

@aminya aminya closed this Sep 19, 2022
@aminya aminya reopened this Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants