-
Notifications
You must be signed in to change notification settings - Fork 89
ci: use setup-cpp to install the compilers #266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
5b4e24e to
f6fe788
Compare
6149ae9 to
14b8d44
Compare
This comment has been minimized.
This comment has been minimized.
b0f1211 to
b34c634
Compare
|
Apologies for being a bit silent, but I will get back to you in a couple of days. I much appreciate the work you're doing. Thanks. |
Codecov Report
@@ Coverage Diff @@
## main #266 +/- ##
===========================================
- Coverage 97.75% 75.77% -21.99%
===========================================
Files 1 1
Lines 890 875 -15
===========================================
- Hits 870 663 -207
- Misses 20 212 +192
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
On the libc++ build/install-script. It's only there because not all versions have readily available downloads (as .deb packages.) If setup-cpp provides the right libc++ versions already, that step can be removed. |
You're welcome!
setup-cpp downloads the original llvm releases, which usually include the libcxx. It does not use apt for this. So, I think we can try removing it. If there is a separate installation step required for libcxx, we can add it to setup-cpp |
|
The libcxx issue is fixed. It required using the correct LLVM_PATH and also passing the CPPFLAGS and LDFLAGS to cmake. |
This comment has been minimized.
This comment has been minimized.
|
Yay! Everything is fixed now. 🎉 |
|
The failures are due to missing coverage reports on some versions, which I think is unrelated to this PR. Right? |
|
I'm not so sure that it is unrelated to the PR. If you look at the "Collect Coverage" step for gcc 4.8, it says: Why is that library missing here? |
|
I updated kcov to v39 because it does not need to be built from the source this way. It might rely on some shared libraries that are missing in the old GCC installer. I need to try install missing packages and see if the issue is fixed. |
|
Sorry for not paying much attention, but the push to finish things before Christmas was a bit intense. I've looked into the current state, and tried to figure out how to move forward, but I haven't been that successful. All builds that use |
|
Of course, a different route forward, that may be easier, is to scrap |
This uses setup-cpp to install the C++ tools
https://github.com/aminya/setup-cpp/
https://github.com/aminya/trompeloeil/actions/runs/1551038387