Skip to content

Conversation

@guitargeek
Copy link
Contributor

@guitargeek guitargeek commented Nov 6, 2025

So far, the R bindings were only built on Ubuntu 22.04, which is becoming a bit dated already.

Since the R bindings usually don't cause any trouble, it would be good to build them on all platforms where we can easily do that.

Fix the following warning:

```txt
math/rtools/src/RMinimizer.cxx:28:19: error: variable length arrays in C++ are a Clang extension [-Werror,-Wvla-cxx-extension]
   28 |          double z[size];
      |                   ^~~~
math/rtools/src/RMinimizer.cxx:28:19: note: read of non-const variable 'size' is not allowed in a constant expression
math/rtools/src/RMinimizer.cxx:26:23: note: declared here
   26 |          unsigned int size = y.GetNoElements();
      |                       ^
```
@github-actions
Copy link

github-actions bot commented Nov 6, 2025

Test Results

    22 files      22 suites   3d 22h 43m 26s ⏱️
 3 707 tests  3 707 ✅ 0 💤 0 ❌
79 681 runs  79 681 ✅ 0 💤 0 ❌

Results for commit 28a5dfa.

♻️ This comment has been updated with latest results.

@guitargeek guitargeek marked this pull request as ready for review November 6, 2025 13:39
@guitargeek guitargeek changed the title [ci] Set r=ON globally to see where we stand with R [ci] Set r=ON where possible Nov 6, 2025
@ferdymercury
Copy link
Collaborator

Side note from:
https://its.cern.ch/jira/browse/ROOT-10756

the R bindings of ROOT were not so popular, the development of these bindings has halted completely, and the "newest" platform that we still support them on right now is Ubuntu 22.04, which is also end-of-life in two years. Our focus is clearly on the Python bindings. So at this point, I don't think we should bother ensuring the right installation behavior for the R libraries.

@guitargeek
Copy link
Contributor Author

That's a good point. Indeed I argued against continuing to develop these R bindings, but as they are already here we should at least test what we have I think. It doesn't cost much

So far, the R bindings were only built on Ubuntu 22.04, which is
becoming a bit dated already.

Since the R bindings usually don't cause any trouble, it would be good
to build them on all platforms where we can easily do that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants