Unit tests for stations_search() #168
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partially addresses ropensci#161
|
HI @kylehamilton, thanks for your contributions! Note that these test failures aren't your problem, and I've fixed the tests on main (API changed one of the data columns). You'll want to update your branch with main to get those fixes here too. Let me know if you have any questions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses request for some unit tests in issue #161
Created unit test for the normals_years variable in the stations_search() function
Description
Created tests checking if the input in normals_years is valid
Related Issue
Partially addresses the request for unit tests in #161
Example
NA
Best Practices
The following have been updated or added as needed:
[NA] Documentation
[NA] Examples in documentation
[NA] Vignettes
[Y]
testthatTests