correct test function descriptions #2970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alsora
approved these changes
Nov 16, 2025
fujitatomoya
approved these changes
Nov 16, 2025
Collaborator
|
@Yuchen966 can you fix the DCO? |
Signed-off-by: Yuchen Liu <[email protected]>
Contributor
|
https://github.com/Mergifyio backport kilted jazzy humble |
Contributor
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 18, 2025
Signed-off-by: Yuchen Liu <[email protected]> (cherry picked from commit 354413c)
mergify bot
pushed a commit
that referenced
this pull request
Nov 18, 2025
Signed-off-by: Yuchen Liu <[email protected]> (cherry picked from commit 354413c)
mergify bot
pushed a commit
that referenced
this pull request
Nov 18, 2025
Signed-off-by: Yuchen Liu <[email protected]> (cherry picked from commit 354413c) # Conflicts: # rclcpp/test/rclcpp/test_intra_process_manager.cpp
ahcorde
pushed a commit
that referenced
this pull request
Nov 18, 2025
(cherry picked from commit 354413c) Signed-off-by: Yuchen Liu <[email protected]> Co-authored-by: Yuchen966 <[email protected]>
ahcorde
pushed a commit
that referenced
this pull request
Nov 18, 2025
(cherry picked from commit 354413c) Signed-off-by: Yuchen Liu <[email protected]> Co-authored-by: Yuchen966 <[email protected]>
ahcorde
added a commit
that referenced
this pull request
Nov 18, 2025
* correct test function descriptions (#2970) Signed-off-by: Yuchen Liu <[email protected]> (cherry picked from commit 354413c) Signed-off-by: Alejandro Hernandez Cordero <[email protected]> Co-authored-by: Yuchen966 <[email protected]> Co-authored-by: Alejandro Hernandez Cordero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current implementation doesn't allow publishing a shared_ptr, so some descriptions of test functions should be changed.
Fixes #2872
Is this user-facing behavior change?
No
Did you use Generative AI?
Yes
Additional Information