Make lazy loading of I18n translations thread safe ( part 2 ) #729
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruby-i18n#644 (comment) When two threads lazy load the translations at the same time, there is a race condition while iterating through the `translations` hash. The first thread merges new values into the hash, and the second thread, while iterating, gets `can't add a new key into hash during iteration` The solution suggested is to use Mutex while merging the hash (which is a mutating action since we're using `merge!` instead of `merge` ) to prevent this from happening cc @mensfeld
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#644 (comment)
When two threads lazy load the translations at the same time, there is a race condition while iterating through the
translationshash. The first thread merges new values into the hash, and the second thread, while iterating, getscan't add a new key into hash during iterationThe solution suggested is to use Mutex while merging the hash (which is a mutating action since we're using
merge!instead ofmerge) to prevent this from happeningcc @mensfeld
Sentry screenshot with relevant stacktrace:
