Add initial K8s web HPA. #5951
Open
Add initial K8s web HPA. #5951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5951 +/- ##
=======================================
Coverage 97.21% 97.21%
=======================================
Files 473 473
Lines 9764 9764
=======================================
Hits 9492 9492
Misses 272 272 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
- I think we need to take a closer look at usage metrics we have in Datadog to see if we're actually hitting 100% CPU. I had some metrics from Kubernetes on my second monitor last week, and I don't think I ever saw the CPU get that high.
- If this change is merged, a quick heads-up that it's almost certainly going to be replaced with a new policy based on queue time (https://judoscale.com/blog/request-queue-time) that I've been building up #5945.
| annotations: | ||
| shipit.shopify.io/restart: 'true' | ||
| spec: | ||
| replicas: <%= environment == 'production' ? 3 : 2 %> |
There was a problem hiding this comment.
Specifying a replica and HPA policy are exclusive, they will try to overwrite one another
| stabilizationWindowSeconds: 60 | ||
| policies: | ||
| - type: Percent | ||
| value: 100 |
There was a problem hiding this comment.
Are our web pods hitting 100% CPU? Can you check with Datadog to review what the ideal CPU usage percentage would be for scaling up?
There was a problem hiding this comment.
Our web pods are not hitting 100+% often, but it has happened a few times in the past month 👇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.