add tob-hard-damage-counter

[aronson]

Theatre of Blood (Hard Mode) Damage Counter Plugin

I made a mod of an existing plugin in the hub to support ToB's hard mode. The old and new plugins work independently.

Changes

• added all unique ToB NpcIDs for hard mode
• updated wave layout for hard mode
• improved win condition detection logic
• sped up event handlers when ToB not active

Code diff

You can review the full diff of changes from the normal mode plugin here (bit of noise in tool scripts I upgraded):
Trevor159/runelite-external-plugins@tob-damage-counter...aronson:hard-tob-damage-counter

The original plugin's manifest in this repo is here and doesn't need to change

Tested

• Tested in a handful of hard mode raids with a group of friends
• Tested in spectator mode
• Tested with original ToB damage counter plugin installed alongside

Main repository

https://github.com/aronson/runelite-external-plugins/tree/hard-tob-damage-counter

This is my first contribution, thank you for reviewing!

[runelite-github-app]

New plugin tob-hard-damage-counter: https://github.com/aronson/runelite-external-plugins/tree/615ac156b551527e1eb4fca0da4835e6edf79ed3

[runelite-github-app]

Internal use only: Reviewer details Maintainer details

[DominickCobb-rs]

Have you considered contributing this functionality to the existing plugin so users don't need to install a separate plugin for the same place?

[aronson]

Have you considered contributing this functionality to the existing plugin so users don't need to install a separate plugin for the same place?

The plugin is unmaintained with no movement in over a year and numerous deprecated field uses, hence this additional plugin. I could pick up the old plugin, would you prefer I do that, merge the two, and take over for both? The manifest for the original would have to change to my sources.

[DominickCobb-rs]

There's a plugin takeover policy that would apply for this

[aronson]

I would prefer to keep them separate. I'm not interested in taking over some older plugin after reading all this. If this is a blocking issue we can close this one.

[Trevor159]

@aronson Hello, I am the original author. I would be happy for you to take over the plugin if you want. I will also merge any PRs to my plugin if that is easier for you (feel free to add yourself as an author, even first idc). I don't care much about code quality so I will probably just accept anything.

I also don't mind it as a separate plugin but it seems that is not preferred.

[riktenx]

@aronson since @Trevor159 is willing to just give you the plugin, and since your repo is a direct fork of theirs, the easiest way forward for everyone involved in this case is just going to be that you update the existing marker file (this one) with your own repo and new commit hash, and then just delete the new marker file you were adding here.

Then I'll just review this as a plugin update, you'll become the owner, and everyone that uses the plugin now will get hard mode support.

[aronson]

That works out great, thank you both for making this easy! I'll need to make small code changes to merge both plugins' features which I'll do now, then proceed to the rest of the update as you've laid out and force-push to this PR. Stay tuned