Skip to content

Conversation

@NorbsCode
Copy link
Contributor

Summary

Updates item-link plugin with performance fixes.

Fixes NorbsCode/item-link#1

Changes:

  • Fix FPS drops caused by widget scanning every frame
  • Optimize string matching using HashSet lookups
  • Add chunked item loading to prevent blocking game client
  • Filter to only highlight player messages (not system/examine text)

Follow-up to #9860

Test plan

  • No FPS drops when typing item names in chat
  • Tooltips display correctly on hover
  • System messages and examine text not highlighted

@runelite-github-app
Copy link

@runelite-github-app
Copy link

Internal use only: Reviewer details Maintainer details

@DominickCobb-rs
Copy link
Contributor

You don't have to close and open new PRs. You just need to update the same file in your PR.

@NorbsCode
Copy link
Contributor Author

You don't have to close and open new PRs. You just need to update the same file in your PR.

Sorry, my bad. First time doing this, do I just leave this one as it is now and wait for someone to review?

@Felanbird
Copy link
Contributor

Making a new PR was correct for this, as you had a mess on your master branch from your original PR.

do I just leave this one as it is now and wait for someone to review?

Yes

@riktenx riktenx merged commit 2558cc4 into runelite:master Dec 23, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Intense lag spikes when doing pretty much anything in the game

4 participants