Update Cox Light Colors to 1.3.4 #9940
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update the logic used to recolor the light above the chest to fix an issue where the correct color would not show with the GPU plugin enabled. It now spawns a fake light object with the correct color and hides the original. - Use clientThread when necessary to avoid assertion errors when working with models - Refactor several methods - Update build.gradle
|
Internal use only: Reviewer details Maintainer details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the chambers light with a fake game object as the old recolor logic was no longer working for the light above the chest. Use client thread where necessary to avoid errors when working with game objects and models.