Skip to content

Test to not report missing element type definitions when tag names which are static class properties #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
driesva wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Test to not report missing element type definitions when tag names which are static class properties #331

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion packages/lit-analyzer/src/test/rules/no-missing-element-type-definition.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ tsTest("'no-missing-element-type-definition' reports diagnostic when element is
hasDiagnostic(t, diagnostics, "no-missing-element-type-definition");
});

tsTest("'no-missing-element-type-definition' reports no diagnostic when element is not in HTMLElementTagNameMap", t => {
tsTest("'no-missing-element-type-definition' reports no diagnostic when element is in HTMLElementTagNameMap", t => {
const { diagnostics } = getDiagnostics(
`
class MyElement extends HTMLElement { };
Expand All @@ -34,3 +34,24 @@ tsTest("'no-missing-element-type-definition' reports no diagnostic when element

hasNoDiagnostics(t, diagnostics);
});

tsTest("'no-missing-element-type-definition' reports no diagnostic when element is in HTMLElementTagNameMap using class property", t => {
const { diagnostics } = getDiagnostics(
`
class MyElement extends HTMLElement {
static readonly TAG_NAME = "my-element"
};
customElements.define(MyElement.TAG_NAME, MyElement)
declare global {
interface HTMLElementTagNameMap {
[MyElement.TAG_NAME]: MyElement
}
}
`,
{
rules: { "no-missing-element-type-definition": true }
}
);

hasNoDiagnostics(t, diagnostics);
});