do not specialise on Copy
#662
Merged
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Nov 22, 2025
library: upgrade to hashbrown v0.16.1 This is another step toward unspecializing `Copy`. See also #135634 and rust-lang/hashbrown#662 r? `@Amanieu` cc `@joboet`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rust-lang/rust#135634 started the process of removing the
#[rustc_unsafe_specialization_marker]onCopyin favour of a newly added traitTrivialClonethat allows sound specialisation by virtue of only being implemented if theCloneimplementation is always equivalent to a copy. However, removing the attribute entirely was not possible in rust-lang/rust#135634 ashashbrowncontains aCopyspecialisation. Thus, this PR removes the relevant specialisation fromhashbrownand switches it to specialise onTrivialCloneinstead.