syntax: Improving the Hir::drop() implementation.
#1331
+89
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hir::drop().
from `Hir::drop()`.
Author
|
Can someone help me fix the msrv failure? The errors says that local_key_cell_methods isn't available on stable yet, but the linked issue says it was stablised in 2023. |
Member
|
They were stabilized in Rust 1.73: https://doc.rust-lang.org/std/thread/struct.LocalKey.html#method.set |
Member
|
Can you say what motivated this? Is there a real world (albeit perhaps minimized) benchmark where this leads to an improvement? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the drop implementation for
Hirinstances allocates heap memory to use as impromptu stack while it walks the Hir tree. With some cleverness, we can reuse the existing allocations forConcatandAlternation, instead.