remove pref_align_of intrinsic handling, rename {min_=>}align_of{,_val}#19984
Merged
Veykril merged 1 commit intorust-lang:masterfrom Jun 14, 2025
Merged
remove pref_align_of intrinsic handling, rename {min_=>}align_of{,_val}#19984Veykril merged 1 commit intorust-lang:masterfrom
pref_align_of intrinsic handling, rename {min_=>}align_of{,_val}#19984Veykril merged 1 commit intorust-lang:masterfrom
Conversation
rustbot
added
the
S-waiting-on-review
Contributor
|
We should wait until that PR is merged so that std switches to the new name. |
Member
|
Ideally we'd support both names for a while, so people who are not using nightly won't have a worse experience, but I'm not sure of the implications in this case (stuff might be broken already). |
Member
Author
|
I guess I could leave |
WaffleLapkin
force-pushed
the
unprefer_align
branch
from
95834ce to
cfc416a
Compare
Member
Author
|
I did the above, this is ready for review |
Veykril
approved these changes
Jun 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See rust-lang/rust#142410
cc @RalfJung