const: don't ICE when encountering a mutable ref to immutable memory#130394
Merged
bors merged 1 commit intorust-lang:masterfrom Sep 16, 2024
Merged
const: don't ICE when encountering a mutable ref to immutable memory#130394bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
Collaborator
rustbot
added
S-waiting-on-review
Collaborator
|
Some changes occurred to the CTFE / Miri interpreter cc @rust-lang/miri |
RalfJung
commented
Sep 15, 2024
| @@ -1,4 +1,3 @@ | |||
| //@ stderr-per-bitwidth | |||
Member
Author
There was a problem hiding this comment.
This is unrelated to the PR, I just noticed there's no reason to have per-bitwidth error files here.
Member
There was a problem hiding this comment.
Yeah there's a lot of silliness in our test annotations. Glad to have a random improvement like this ❤️
RalfJung
force-pushed
the
mut-ref-to-immut
branch
from
f6f9a13 to
d4918df
Compare
Member
|
r? saethlin |
Collaborator
bors
added
S-waiting-on-bors
Collaborator
|
☔ The latest upstream changes (presumably #130390) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 15, 2024
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#129439 (Implement feature `string_from_utf8_lossy_owned` for lossy conversion from `Vec<u8>` to `String` methods) - rust-lang#129828 (miri: treat non-memory local variables properly for data race detection) - rust-lang#130110 (make dist vendoring configurable) - rust-lang#130293 (Fix lint levels not getting overridden by attrs on `Stmt` nodes) - rust-lang#130342 (interpret, miri: fix dealing with overflow during slice indexing and allocation) Failed merges: - rust-lang#130394 (const: don't ICE when encountering a mutable ref to immutable memory) r? `@ghost` `@rustbot` modify labels: rollup
RalfJung
force-pushed
the
mut-ref-to-immut
branch
from
d4918df to
7dfffe7
Compare
Member
Author
|
@bors r=saethlin |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 15, 2024
…iaskrgr Rollup of 3 pull requests Successful merges: - rust-lang#130151 (Use a small runner for msvc-ext2 job) - rust-lang#130394 (const: don't ICE when encountering a mutable ref to immutable memory) - rust-lang#130409 (tests: more ice tests) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 16, 2024
Rollup merge of rust-lang#130394 - RalfJung:mut-ref-to-immut, r=saethlin const: don't ICE when encountering a mutable ref to immutable memory Turns out that this can actually happen -- thanks to `@matthiaskrgr` for producing a testcase. :) Fixes rust-lang#130392
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out that this can actually happen -- thanks to @matthiaskrgr for producing a testcase. :)
Fixes #130392