Fix asm goto with outputs and move it to a separate feature gate#131523
Merged
bors merged 3 commits intorust-lang:masterfrom Nov 25, 2024
Merged
Fix asm goto with outputs and move it to a separate feature gate#131523bors merged 3 commits intorust-lang:masterfrom
bors merged 3 commits intorust-lang:masterfrom
Conversation
Collaborator
rustbot
added
S-waiting-on-review
Collaborator
|
☔ The latest upstream changes (presumably #132027) made this pull request unmergeable. Please resolve the merge conflicts. |
Contributor
|
r? compiler-errors I'll review this, please ping me if I don't get to it in a few days |
Collaborator
|
☔ The latest upstream changes (presumably #132470) made this pull request unmergeable. Please resolve the merge conflicts. |
53 tasks
Member
Author
|
ping @compiler-errors |
compiler-errors
approved these changes
Nov 24, 2024
Contributor
compiler-errors
left a comment
compiler-errors
left a comment
There was a problem hiding this comment.
One nit then r=me
| let mut _out: u64; | ||
| unsafe { | ||
| asm!("mov {}, 1", "jmp {}", out(reg) _out, label {}); | ||
| //~^ ERROR using both label and outputs operands for inline assembly is unstable |
Contributor
There was a problem hiding this comment.
Is this a typo? I think it should be "label and output operands"
Contributor
|
@bors delegate+ |
Collaborator
|
✌️ @nbdd0121, you can now approve this pull request! If @compiler-errors told you to " |
Contributor
|
You also may want to rebase this PR just in case |
compiler-errors
added
S-waiting-on-author
When outputs are used together with labels, they are considered to be written for all destinations, not only when falling through.
When labels are present, the `noreturn` option really means that asm block won't fallthrough -- if labels are present, then outputs can still be meaningfully used.
Contributor
|
@bors r+ |
Collaborator
bors
removed
the
S-waiting-on-author
bors
added
the
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 25, 2024
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#131523 (Fix asm goto with outputs and move it to a separate feature gate) - rust-lang#131664 (Support input/output in vector registers of s390x inline assembly (under asm_experimental_reg feature)) - rust-lang#132432 (Add a test to verify that libstd doesn't use protected symbols) - rust-lang#132502 (Document possibility to set core features in example config.toml) - rust-lang#132529 (ci(triagebot): add more top-level files to A-meta) - rust-lang#132533 (Add BorrowedBuf::into_filled{,_mut} methods to allow returning buffer with original lifetime) - rust-lang#132803 (Fix broken url) - rust-lang#132982 (alloc: fix `Allocator` method names in `alloc` free function docs) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 25, 2024
Rollup merge of rust-lang#131523 - nbdd0121:asm, r=compiler-errors Fix asm goto with outputs and move it to a separate feature gate Tracking issue: rust-lang#119364 This PR addresses 3 aspects of asm goto with outputs: * Codegen is fixed. My initial implementation has an oversight which cause the output to be only stored in fallthrough path, but not in label blocks. * Outputs can now be used with `options(noreturn)` if a label block is given. * All of this is moved to a new feature gate, because we likely want to stabilise `asm_goto` before asm goto with outputs. `@rustbot` labels: +A-inline-assembly +F-asm
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue: #119364
This PR addresses 3 aspects of asm goto with outputs:
options(noreturn)if a label block is given.asm_gotobefore asm goto with outputs.@rustbot labels: +A-inline-assembly +F-asm