Add `-Zindirect-branch-cs-prefix` by ojeda · Pull Request #140740 · rust-lang/rust

ojeda · 2025-05-07T13:55:12Z

This goes on top of #135927, i.e. please skip the first commit here. Please feel free to inherit it there.

In fact, I am not sure if there is any use case for the flag without -Zretpoline*. GCC and Clang allow it, though.

There is a FIXME for two ignores in the test that I took from another test I did in the past -- they may be needed or not here since I didn't run the full CI. Either way, it is not critical.

Tracking issue: #116852.
MCP: rust-lang/compiler-team#899.

ojeda · 2025-05-07T14:19:09Z

@rustbot label F-target_modifiers A-rust-for-linux

ojeda · 2025-05-07T14:32:20Z

The error is related to the base PR -- I think this one should be clean (modulo the marked ignore-*s) when that one is.

src/doc/unstable-book/src/compiler-flags/indirect-branch-cs-prefix.md

rustbot · 2025-06-16T04:39:53Z

r? @compiler-errors

rustbot has assigned @compiler-errors.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Darksonn · 2025-07-02T11:57:39Z

Assigning same reviewer as #135927.

r? @davidtwco

Zalathar · 2025-08-15T06:12:19Z

Failed in rollup: #145418 (comment)

@bors r-

This is intended to be used for Linux kernel RETPOLINE builds. Signed-off-by: Miguel Ojeda <[email protected]>

rustbot · 2025-08-17T14:52:52Z

This PR was rebased onto a different master commit! Check out the changes with our range-diff.

ojeda · 2025-08-17T14:53:34Z

Failed in rollup: #145418 (comment)

@bors r-

This is what I suspected in #140740 (comment) -- I have re-added the Apple one.

davidtwco · 2025-08-18T12:43:02Z

@bors r+

bors · 2025-08-18T12:43:06Z

📌 Commit 1a29d9c has been approved by davidtwco

It is now in the queue for this repository.

…=davidtwco Add `-Zindirect-branch-cs-prefix` Cc: `@azhogin` `@Darksonn` This goes on top of rust-lang#135927, i.e. please skip the first commit here. Please feel free to inherit it there. In fact, I am not sure if there is any use case for the flag without `-Zretpoline*`. GCC and Clang allow it, though. There is a `FIXME` for two `ignore`s in the test that I took from another test I did in the past -- they may be needed or not here since I didn't run the full CI. Either way, it is not critical. Tracking issue: rust-lang#116852. MCP: rust-lang/compiler-team#868.

…=davidtwco Add `-Zindirect-branch-cs-prefix` Cc: ``@azhogin`` ``@Darksonn`` This goes on top of rust-lang#135927, i.e. please skip the first commit here. Please feel free to inherit it there. In fact, I am not sure if there is any use case for the flag without `-Zretpoline*`. GCC and Clang allow it, though. There is a `FIXME` for two `ignore`s in the test that I took from another test I did in the past -- they may be needed or not here since I didn't run the full CI. Either way, it is not critical. Tracking issue: rust-lang#116852. MCP: rust-lang/compiler-team#868.

Rollup of 33 pull requests Successful merges: - #139345 (Extend `QueryStability` to handle `IntoIterator` implementations) - #140740 (Add `-Zindirect-branch-cs-prefix`) - #142079 (nll-relate: improve hr opaque types support) - #142938 (implement std::fs::set_permissions_nofollow on unix) - #144767 (Correct some grammar in integer documentation) - #144906 (Require approval from t-infra instead of t-release on tier bumps) - #144983 (Rehome 37 `tests/ui/issues/` tests to other subdirectories under `tests/ui/`) - #145025 (run spellcheck as a tidy extra check in ci) - #145166 (suggest using `pub(crate)` for E0364) - #145255 (dec2flt: Provide more valid inputs examples) - #145306 (Add tracing to various miscellaneous functions) - #145336 (Hide docs for `core::unicode`) - #145429 (Couple of codegen_fn_attrs improvements) - #145452 (Do not strip binaries in bootstrap everytime if they are unchanged) - #145464 (Stabilize `const_pathbuf_osstring_new` feature) - #145474 (Properly recover from parenthesized use-bounds (precise capturing lists) plus small cleanups) - #145486 (Fix `unicode_data.rs` mention message) - #145493 (remove `should_render` in `PrintAttribute` derive) - #145505 (Simplify span caches) - #145510 (Visit and print async_fut local for async drop.) - #145511 (Rust build fails on OpenBSD after using file_lock feature) - #145532 (resolve: debug for block module) - #145533 (Reorder `lto` options from most to least optimizing) - #145537 (Do not consider a `T: !Sized` candidate to satisfy a `T: !MetaSized` obligation.) - #145538 (bufreader::Buffer::backshift: don't move the uninit bytes) - #145542 (triagebot: Don't warn no-mentions on subtree updates) - #145549 (Update rust maintainers in openharmony.md) - #145550 (Avoid using `()` in `derive(From)` output.) - #145556 (Allow stability attributes on extern crates) - #145560 (Remove unused `PartialOrd`/`Ord` from bootstrap) - #145568 (ignore frontmatters in `TokenStream::new`) - #145571 (remove myself from some adhoc-groups and pings) - #145576 (Add change tracker entry for `--timings`) r? `@ghost` `@rustbot` modify labels: rollup

…=davidtwco Add `-Zindirect-branch-cs-prefix` Cc: `@azhogin` `@Darksonn` This goes on top of rust-lang#135927, i.e. please skip the first commit here. Please feel free to inherit it there. In fact, I am not sure if there is any use case for the flag without `-Zretpoline*`. GCC and Clang allow it, though. There is a `FIXME` for two `ignore`s in the test that I took from another test I did in the past -- they may be needed or not here since I didn't run the full CI. Either way, it is not critical. Tracking issue: rust-lang#116852. MCP: rust-lang/compiler-team#868.

Rollup of 15 pull requests Successful merges: - #139345 (Extend `QueryStability` to handle `IntoIterator` implementations) - #140740 (Add `-Zindirect-branch-cs-prefix`) - #142079 (nll-relate: improve hr opaque types support) - #142938 (implement std::fs::set_permissions_nofollow on unix) - #143730 (fmt of non-decimal radix untangled) - #144767 (Correct some grammar in integer documentation) - #144906 (Require approval from t-infra instead of t-release on tier bumps) - #144983 (Rehome 37 `tests/ui/issues/` tests to other subdirectories under `tests/ui/`) - #145025 (run spellcheck as a tidy extra check in ci) - #145099 (rustc_target: Add the `32s` target feature for LoongArch) - #145166 (suggest using `pub(crate)` for E0364) - #145255 (dec2flt: Provide more valid inputs examples) - #145306 (Add tracing to various miscellaneous functions) - #145336 (Hide docs for `core::unicode`) - #145585 (Miri: fix handling of in-place argument and return place handling) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #140740 - ojeda:indirect-branch-cs-prefix, r=davidtwco Add `-Zindirect-branch-cs-prefix` Cc: ``@azhogin`` ``@Darksonn`` This goes on top of #135927, i.e. please skip the first commit here. Please feel free to inherit it there. In fact, I am not sure if there is any use case for the flag without `-Zretpoline*`. GCC and Clang allow it, though. There is a `FIXME` for two `ignore`s in the test that I took from another test I did in the past -- they may be needed or not here since I didn't run the full CI. Either way, it is not critical. Tracking issue: #116852. MCP: rust-lang/compiler-team#868.

Rollup of 15 pull requests Successful merges: - rust-lang#139345 (Extend `QueryStability` to handle `IntoIterator` implementations) - rust-lang#140740 (Add `-Zindirect-branch-cs-prefix`) - rust-lang#142079 (nll-relate: improve hr opaque types support) - rust-lang#142938 (implement std::fs::set_permissions_nofollow on unix) - rust-lang#143730 (fmt of non-decimal radix untangled) - rust-lang#144767 (Correct some grammar in integer documentation) - rust-lang#144906 (Require approval from t-infra instead of t-release on tier bumps) - rust-lang#144983 (Rehome 37 `tests/ui/issues/` tests to other subdirectories under `tests/ui/`) - rust-lang#145025 (run spellcheck as a tidy extra check in ci) - rust-lang#145099 (rustc_target: Add the `32s` target feature for LoongArch) - rust-lang#145166 (suggest using `pub(crate)` for E0364) - rust-lang#145255 (dec2flt: Provide more valid inputs examples) - rust-lang#145306 (Add tracing to various miscellaneous functions) - rust-lang#145336 (Hide docs for `core::unicode`) - rust-lang#145585 (Miri: fix handling of in-place argument and return place handling) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 15 pull requests Successful merges: - rust-lang/rust#139345 (Extend `QueryStability` to handle `IntoIterator` implementations) - rust-lang/rust#140740 (Add `-Zindirect-branch-cs-prefix`) - rust-lang/rust#142079 (nll-relate: improve hr opaque types support) - rust-lang/rust#142938 (implement std::fs::set_permissions_nofollow on unix) - rust-lang/rust#143730 (fmt of non-decimal radix untangled) - rust-lang/rust#144767 (Correct some grammar in integer documentation) - rust-lang/rust#144906 (Require approval from t-infra instead of t-release on tier bumps) - rust-lang/rust#144983 (Rehome 37 `tests/ui/issues/` tests to other subdirectories under `tests/ui/`) - rust-lang/rust#145025 (run spellcheck as a tidy extra check in ci) - rust-lang/rust#145099 (rustc_target: Add the `32s` target feature for LoongArch) - rust-lang/rust#145166 (suggest using `pub(crate)` for E0364) - rust-lang/rust#145255 (dec2flt: Provide more valid inputs examples) - rust-lang/rust#145306 (Add tracing to various miscellaneous functions) - rust-lang/rust#145336 (Hide docs for `core::unicode`) - rust-lang/rust#145585 (Miri: fix handling of in-place argument and return place handling) r? `@ghost` `@rustbot` modify labels: rollup

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 7, 2025

ojeda mentioned this pull request May 7, 2025

Add -Zindirect-branch-cs-prefix #140733

Closed

ojeda force-pushed the indirect-branch-cs-prefix branch from 4422b3c to 0582d8f Compare May 7, 2025 14:07

ojeda mentioned this pull request May 7, 2025

rustc wanted features & bugfixes Rust-for-Linux/linux#355

Open

64 tasks

ojeda force-pushed the indirect-branch-cs-prefix branch from 0582d8f to b0392c5 Compare May 7, 2025 14:16

rustbot added A-rust-for-linux Relevant for the Rust-for-Linux project F-target_modifiers `#![feature(target_modifiers)]` labels May 7, 2025

This comment has been minimized.

Sign in to view

ojeda force-pushed the indirect-branch-cs-prefix branch from b0392c5 to f395de3 Compare May 7, 2025 15:01

This comment has been minimized.

Sign in to view

ojeda force-pushed the indirect-branch-cs-prefix branch from f395de3 to a79ff99 Compare May 7, 2025 17:15

This comment has been minimized.

Sign in to view

ojeda mentioned this pull request May 7, 2025

retpoline and retpoline-external-thunk flags (target modifiers) to enable retpoline-related target features #135927

Merged

Darksonn reviewed May 8, 2025

View reviewed changes

src/doc/unstable-book/src/compiler-flags/indirect-branch-cs-prefix.md Outdated Show resolved Hide resolved

ojeda force-pushed the indirect-branch-cs-prefix branch from a79ff99 to 879a3bc Compare May 8, 2025 17:09

rustbot added the A-rustdoc-json Area: Rustdoc JSON backend label May 8, 2025

This comment has been minimized.

Sign in to view

ojeda mentioned this pull request May 20, 2025

Getting Rust for Linux into stable Rust: language features rust-lang/rust-project-goals#116

Open

53 tasks

This comment was marked as resolved.

Sign in to view

ojeda force-pushed the indirect-branch-cs-prefix branch from 879a3bc to 331c2b6 Compare June 15, 2025 12:47

rustbot added the A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. label Jun 15, 2025

ojeda marked this pull request as ready for review June 16, 2025 04:39

rustbot assigned compiler-errors Jun 16, 2025

ojeda changed the title ~~-Zindirect-branch-cs-prefix on top of -Zretpoline*~~ Add -Zindirect-branch-cs-prefix Jun 16, 2025

rustbot assigned davidtwco Jul 2, 2025

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 15, 2025

Darksonn and others added 2 commits August 17, 2025 16:50

Add -Zindirect-branch-cs-prefix (from draft PR)

1cd7080

Add -Zindirect-branch-cs-prefix option

1a29d9c

This is intended to be used for Linux kernel RETPOLINE builds. Signed-off-by: Miguel Ojeda <[email protected]>

ojeda force-pushed the indirect-branch-cs-prefix branch from 74ebaf9 to 1a29d9c Compare August 17, 2025 14:52

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 18, 2025

jhpratt mentioned this pull request Aug 18, 2025

Rollup of 33 pull requests #145588

Closed

This was referenced Aug 19, 2025

Rollup of 17 pull requests #145598

Closed

Rollup of 15 pull requests #145599

Merged

bors merged commit df01a87 into rust-lang:master Aug 19, 2025
10 checks passed

rustbot added this to the 1.91.0 milestone Aug 19, 2025

This was referenced Aug 19, 2025

Rust unstable features needed for the kernel Rust-for-Linux/linux#2

Open

Retpoline support in rustc (target features or dedicated flags) #116852

Open

jieyouxu added the -Zindirect-branch-cs-prefix Unstable option: -Zindirect-branch-cs-prefix label Aug 24, 2025

ojeda deleted the indirect-branch-cs-prefix branch August 27, 2025 18:08

tomassedovic mentioned this pull request Oct 9, 2025

Getting Rust for Linux into stable Rust: compiler features rust-lang/rust-project-goals#407

Open

29 tasks

Uh oh!

Conversation

ojeda commented May 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ojeda commented May 7, 2025

Uh oh!

This comment has been minimized.

ojeda commented May 7, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

This comment has been minimized.

This comment was marked as resolved.

rustbot commented Jun 16, 2025

Uh oh!

Darksonn commented Jul 2, 2025

Uh oh!

Zalathar commented Aug 15, 2025

Uh oh!

rustbot commented Aug 17, 2025

Uh oh!

ojeda commented Aug 17, 2025

Uh oh!

davidtwco commented Aug 18, 2025

Uh oh!

bors commented Aug 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

ojeda commented May 7, 2025 •

edited

Loading