`tests/ui`: A New Order [13/N] by Kivooeo · Pull Request #142429 · rust-lang/rust

Kivooeo · 2025-06-12T17:09:39Z

Some tests/ui/ housekeeping, to trim down number of tests directly under tests/ui/. Part of #133895.

bors · 2025-06-24T14:33:45Z

☔ The latest upstream changes (presumably #142956) made this pull request unmergeable. Please resolve the merge conflicts.

rustbot · 2025-06-24T18:09:44Z

There are changes to the tidy tool.

cc @jieyouxu

jieyouxu

Thanks, some nits, and then can you squash or otherwise split into the {move, edits} commits for better git history as discussed elsewhere.

tests/ui/traits/dispatch-from-dyn-invalid-impls.rs

tests/ui/mismatched_types/int-float-type-mismatch.rs

Kivooeo · 2025-06-28T14:05:46Z

@rustbot ready

tests/ui/traits/dispatch-from-dyn-invalid-impls.rs

jieyouxu · 2025-06-29T10:23:35Z

One nit on error annotation "lookalikes"
@rustbot author

rustbot · 2025-06-29T10:23:38Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

Kivooeo · 2025-06-29T10:25:35Z

Also are you still working on compiletest? Because original tracking issue seems like wasn't updated for a long time

Upd: nvm it was updated 5 days ago

jieyouxu · 2025-06-29T10:29:37Z

Also are you still working on compiletest? Because original tracking issue seems like wasn't updated for a long time

Yes. If you mean all the implementation PRs, then I also clarified on the PR listing

Note: these are some of the earlier PRs (so not necessarily exhaustive), I may stop updating this listing if we have more PRs.

Because there's quite a few of them.

src/tools/tidy/src/issues.txt

jieyouxu · 2025-06-29T10:57:51Z

Thanks, r=me once PR CI is green.
@bors delegate+ rollup

bors · 2025-06-29T10:57:54Z

✌️ @Kivooeo, you can now approve this pull request!

If @jieyouxu told you to "r=me" after making some further change, please make that change, then do @bors r=@jieyouxu

Kivooeo · 2025-06-29T12:22:50Z

@bors r=@jieyouxu

bors · 2025-06-29T12:22:52Z

📌 Commit d0bd279 has been approved by jieyouxu

It is now in the queue for this repository.

`tests/ui`: A New Order [13/N] Some `tests/ui/` housekeeping, to trim down number of tests directly under `tests/ui/`. Part of rust-lang#133895. r? `@jieyouxu`

Rollup of 7 pull requests Successful merges: - #142429 (`tests/ui`: A New Order [13/N]) - #143066 (Use let chains in the new solver) - #143156 (inherit `#[align]` from trait method prototypes) - #143176 (fix typos and improve clarity in documentation) - #143187 (Add my work email to mailmap) - #143194 (fix bitcast of single-element SIMD vectors) - #143199 (Re-disable `tests/run-make/short-ice` on Windows MSVC again) r? `@ghost` `@rustbot` modify labels: rollup

`tests/ui`: A New Order [13/N] Some `tests/ui/` housekeeping, to trim down number of tests directly under `tests/ui/`. Part of rust-lang#133895. r? ``@jieyouxu``

Rollup of 7 pull requests Successful merges: - #142429 (`tests/ui`: A New Order [13/N]) - #143066 (Use let chains in the new solver) - #143156 (inherit `#[align]` from trait method prototypes) - #143176 (fix typos and improve clarity in documentation) - #143187 (Add my work email to mailmap) - #143199 (Re-disable `tests/run-make/short-ice` on Windows MSVC again) - #143219 (Show auto trait and blanket impls for `!`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 14 pull requests Successful merges: - #142429 (`tests/ui`: A New Order [13/N]) - #142514 (Miri: handling of SNaN inputs in `f*::pow` operations) - #143066 (Use let chains in the new solver) - #143090 (Workaround for memory unsafety in third party DLLs) - #143118 (`tests/ui`: A New Order [15/N]) - #143159 (Do not freshen `ReError`) - #143168 (`tests/ui`: A New Order [16/N]) - #143176 (fix typos and improve clarity in documentation) - #143187 (Add my work email to mailmap) - #143190 (Use the `new` method for `BasicBlockData` and `Statement`) - #143195 (`tests/ui`: A New Order [17/N]) - #143196 (Port #[link_section] to the new attribute parsing infrastructure) - #143199 (Re-disable `tests/run-make/short-ice` on Windows MSVC again) - #143219 (Show auto trait and blanket impls for `!`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #142429 - Kivooeo:tf13, r=jieyouxu `tests/ui`: A New Order [13/N] Some `tests/ui/` housekeeping, to trim down number of tests directly under `tests/ui/`. Part of #133895. r? ```@jieyouxu```

Rollup of 14 pull requests Successful merges: - rust-lang/rust#142429 (`tests/ui`: A New Order [13/N]) - rust-lang/rust#142514 (Miri: handling of SNaN inputs in `f*::pow` operations) - rust-lang/rust#143066 (Use let chains in the new solver) - rust-lang/rust#143090 (Workaround for memory unsafety in third party DLLs) - rust-lang/rust#143118 (`tests/ui`: A New Order [15/N]) - rust-lang/rust#143159 (Do not freshen `ReError`) - rust-lang/rust#143168 (`tests/ui`: A New Order [16/N]) - rust-lang/rust#143176 (fix typos and improve clarity in documentation) - rust-lang/rust#143187 (Add my work email to mailmap) - rust-lang/rust#143190 (Use the `new` method for `BasicBlockData` and `Statement`) - rust-lang/rust#143195 (`tests/ui`: A New Order [17/N]) - rust-lang/rust#143196 (Port #[link_section] to the new attribute parsing infrastructure) - rust-lang/rust#143199 (Re-disable `tests/run-make/short-ice` on Windows MSVC again) - rust-lang/rust#143219 (Show auto trait and blanket impls for `!`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 14 pull requests Successful merges: - rust-lang#142429 (`tests/ui`: A New Order [13/N]) - rust-lang#142514 (Miri: handling of SNaN inputs in `f*::pow` operations) - rust-lang#143066 (Use let chains in the new solver) - rust-lang#143090 (Workaround for memory unsafety in third party DLLs) - rust-lang#143118 (`tests/ui`: A New Order [15/N]) - rust-lang#143159 (Do not freshen `ReError`) - rust-lang#143168 (`tests/ui`: A New Order [16/N]) - rust-lang#143176 (fix typos and improve clarity in documentation) - rust-lang#143187 (Add my work email to mailmap) - rust-lang#143190 (Use the `new` method for `BasicBlockData` and `Statement`) - rust-lang#143195 (`tests/ui`: A New Order [17/N]) - rust-lang#143196 (Port #[link_section] to the new attribute parsing infrastructure) - rust-lang#143199 (Re-disable `tests/run-make/short-ice` on Windows MSVC again) - rust-lang#143219 (Show auto trait and blanket impls for `!`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 14 pull requests Successful merges: - rust-lang/rust#142429 (`tests/ui`: A New Order [13/N]) - rust-lang/rust#142514 (Miri: handling of SNaN inputs in `f*::pow` operations) - rust-lang/rust#143066 (Use let chains in the new solver) - rust-lang/rust#143090 (Workaround for memory unsafety in third party DLLs) - rust-lang/rust#143118 (`tests/ui`: A New Order [15/N]) - rust-lang/rust#143159 (Do not freshen `ReError`) - rust-lang/rust#143168 (`tests/ui`: A New Order [16/N]) - rust-lang/rust#143176 (fix typos and improve clarity in documentation) - rust-lang/rust#143187 (Add my work email to mailmap) - rust-lang/rust#143190 (Use the `new` method for `BasicBlockData` and `Statement`) - rust-lang/rust#143195 (`tests/ui`: A New Order [17/N]) - rust-lang/rust#143196 (Port #[link_section] to the new attribute parsing infrastructure) - rust-lang/rust#143199 (Re-disable `tests/run-make/short-ice` on Windows MSVC again) - rust-lang/rust#143219 (Show auto trait and blanket impls for `!`) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned jieyouxu Jun 12, 2025

This comment has been minimized.

Sign in to view

Kivooeo force-pushed the tf13 branch from 074aace to 529fa97 Compare June 24, 2025 18:09

jieyouxu requested changes Jun 28, 2025

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 28, 2025

Kivooeo force-pushed the tf13 branch from 529fa97 to 7161258 Compare June 28, 2025 11:22

This comment has been minimized.

Sign in to view

Kivooeo force-pushed the tf13 branch from 7161258 to aef01df Compare June 28, 2025 12:37

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 28, 2025

jieyouxu reviewed Jun 29, 2025

View reviewed changes

tests/ui/traits/dispatch-from-dyn-invalid-impls.rs Outdated Show resolved Hide resolved

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 29, 2025

rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 29, 2025

Kivooeo force-pushed the tf13 branch from aef01df to 91d7c30 Compare June 29, 2025 10:37

cleaned up some tests

d0bd279

Kivooeo force-pushed the tf13 branch from 91d7c30 to d0bd279 Compare June 29, 2025 10:37

jieyouxu reviewed Jun 29, 2025

View reviewed changes

src/tools/tidy/src/issues.txt Show resolved Hide resolved

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 29, 2025

GuillaumeGomez mentioned this pull request Jun 29, 2025

Rollup of 7 pull requests #143211

Closed

Kivooeo mentioned this pull request Jun 29, 2025

tests/ui: A New Order [15/N] #143118

Merged

matthiaskrgr mentioned this pull request Jun 30, 2025

Rollup of 7 pull requests #143225

Closed

dianqk mentioned this pull request Jun 30, 2025

Rollup of 14 pull requests #143233

Merged

bors merged commit 384d699 into rust-lang:master Jun 30, 2025
10 checks passed

rustbot added this to the 1.90.0 milestone Jun 30, 2025

Uh oh!

Conversation

Kivooeo commented Jun 12, 2025 • edited by jieyouxu Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

bors commented Jun 24, 2025

Uh oh!

rustbot commented Jun 24, 2025

Uh oh!

jieyouxu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

Kivooeo commented Jun 28, 2025

Uh oh!

Uh oh!

jieyouxu commented Jun 29, 2025

Uh oh!

rustbot commented Jun 29, 2025

Uh oh!

Kivooeo commented Jun 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jieyouxu commented Jun 29, 2025

Uh oh!

Uh oh!

jieyouxu commented Jun 29, 2025

Uh oh!

bors commented Jun 29, 2025

Uh oh!

Kivooeo commented Jun 29, 2025

Uh oh!

bors commented Jun 29, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Kivooeo commented Jun 12, 2025 •

edited by jieyouxu

Loading

Kivooeo commented Jun 29, 2025 •

edited

Loading