Skip to content

bump std libc dependency#142509

Closed
the8472 wants to merge 1 commit intorust-lang:masterfrom
the8472:bump-libc
Closed

bump std libc dependency#142509
the8472 wants to merge 1 commit intorust-lang:masterfrom
the8472:bump-libc

Conversation

@the8472
Copy link
Member

@the8472 the8472 commented Jun 14, 2025 •
edited
Loading

Bump libc, it contains prerequisites for a #140867 fix

rust-lang/libc@0.2.172...0.2.174

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jun 14, 2025
@the8472 the8472 marked this pull request as ready for review June 14, 2025 15:03
@rustbot
Copy link
Collaborator

rustbot commented Jun 14, 2025

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 14, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 14, 2025

These commits modify the library/Cargo.lock file. Unintentional changes to library/Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@workingjubilee
Copy link
Member

workingjubilee commented Jun 14, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 14, 2025

📌 Commit e48da37 has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 14, 2025
fmease added a commit to fmease/rust that referenced this pull request Jun 14, 2025
@fmease
Rollup merge of rust-lang#142509 - the8472:bump-libc, r=workingjubilee
69a1e83 
bump std libc dependency

Bump libc, it contains prerequisites for a rust-lang#140867 fix
@fmease fmease mentioned this pull request Jun 14, 2025
Closed
bors added a commit that referenced this pull request Jun 15, 2025
@bors
Auto merge of #142522 - fmease:rollup-t1mkos2, r=fmease
cf4477b 
Rollup of 10 pull requests

Successful merges:

 - #133952 (Remove wasm legacy abi)
 - #134661 (Reduce precedence of expressions that have an outer attr)
 - #141769 (Move metadata object generation for dylibs to the linker code )
 - #141864 (Handle win32 separator for cygwin paths)
 - #142347 (Async drop - fix for StorageLive/StorageDead codegen for pinned future)
 - #142377 (Try unremapping compiler sources)
 - #142389 (Apply ABI attributes on return types in `rustc_codegen_cranelift`)
 - #142470 (Add some missing mailmap entries)
 - #142481 (Add `f16` inline asm support for LoongArch)
 - #142509 (bump std libc dependency)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 15, 2025
@matthiaskrgr
Rollup merge of rust-lang#142509 - the8472:bump-libc, r=workingjubilee
57654d4 
bump std libc dependency

Bump libc, it contains prerequisites for a rust-lang#140867 fix
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 15, 2025
Closed
bors added a commit that referenced this pull request Jun 15, 2025
@bors
Auto merge of #142533 - matthiaskrgr:rollup-catmreo, r=matthiaskrgr
07029f5 
Rollup of 9 pull requests

Successful merges:

 - #133952 (Remove wasm legacy abi)
 - #141769 (Move metadata object generation for dylibs to the linker code )
 - #141864 (Handle win32 separator for cygwin paths)
 - #142347 (Async drop - fix for StorageLive/StorageDead codegen for pinned future)
 - #142377 (Try unremapping compiler sources)
 - #142389 (Apply ABI attributes on return types in `rustc_codegen_cranelift`)
 - #142470 (Add some missing mailmap entries)
 - #142481 (Add `f16` inline asm support for LoongArch)
 - #142509 (bump std libc dependency)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 15, 2025
@matthiaskrgr
Rollup merge of rust-lang#142509 - the8472:bump-libc, r=workingjubilee
bf2794a 
bump std libc dependency

Bump libc, it contains prerequisites for a rust-lang#140867 fix
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 15, 2025
Closed
bors added a commit that referenced this pull request Jun 15, 2025
@bors
Auto merge of #142535 - matthiaskrgr:rollup-7is2fad, r=matthiaskrgr
8d94b0d 
Rollup of 8 pull requests

Successful merges:

 - #133952 (Remove wasm legacy abi)
 - #141769 (Move metadata object generation for dylibs to the linker code )
 - #141864 (Handle win32 separator for cygwin paths)
 - #142347 (Async drop - fix for StorageLive/StorageDead codegen for pinned future)
 - #142389 (Apply ABI attributes on return types in `rustc_codegen_cranelift`)
 - #142470 (Add some missing mailmap entries)
 - #142481 (Add `f16` inline asm support for LoongArch)
 - #142509 (bump std libc dependency)

r? `@ghost`
`@rustbot` modify labels: rollup
@fmease
Copy link
Member

fmease commented Jun 15, 2025 •
edited
Loading

Likely the cause of this rollup failure: #142535 (comment)
@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 15, 2025
@fmease
Copy link
Member

fmease commented Jun 15, 2025 •
edited
Loading

Likely due to rust-lang/libc#4433 (grep for tv_nsec in the patch set)

@the8472
Copy link
Member Author

the8472 commented Jun 15, 2025

@tgross35 was backporting that API break to 0.2 intentional?

@tgross35
Copy link
Contributor

tgross35 commented Jun 15, 2025

No breakage was intentional, that change wasn’t supposed to be user-visible without setting the unstable env. I’ll try to get a fix out today.

Mark-Simulacrum added a commit that referenced this pull request Jun 16, 2025
@Mark-Simulacrum
Temporarily downgrade libc bumps
ed04290 
See #142509 (comment)
@tgross35
Copy link
Contributor

tgross35 commented Jun 17, 2025

Took longer than I expected unfortunately but the fix is released in 0.2.174

@the8472
Copy link
Member Author

the8472 commented Jun 18, 2025

@bors r=workingjubilee rollup=iffy

@bors
Copy link
Collaborator

bors commented Jun 18, 2025

📌 Commit f800469 has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 18, 2025
@tgross35
Copy link
Contributor

tgross35 commented Jun 19, 2025

@bors r-

#142524 got the update to 0.2.174 so this isn't needed anymore

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 19, 2025
@the8472
Copy link
Member Author

the8472 commented Jun 24, 2025

Well I also wanted to Cargo.toml bump, but I can do that in a PR that actually uses the new API.

@the8472 the8472 closed this Jun 24, 2025
@the8472 the8472 deleted the bump-libc branch June 24, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@joboet joboet

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@the8472 @rustbot @workingjubilee @bors @fmease @tgross35 @joboet