Constify `Index` traits by oli-obk · Pull Request #143921 · rust-lang/rust

oli-obk · 2025-07-14T09:17:33Z

tracking issue: #143775

the SliceIndex trait cannot be implemented by users as it is sealed. While it would be useful for the get method on slices, it seems weird to have a feature gate for that that isn't also gating index syntax at the same time, so I put them under the same feature gate.

r? @fee1-dead

fee1-dead

really nice. I'm happy that this was done without any change to the actual logic :D

fee1-dead · 2025-07-14T10:50:40Z

@bors r+ rollup

bors · 2025-07-14T10:50:43Z

📌 Commit 8b350d5 has been approved by fee1-dead

It is now in the queue for this repository.

Constify `Index` traits tracking issue: rust-lang#143775 the `SliceIndex` trait cannot be implemented by users as it is sealed. While it would be useful for the `get` method on slices, it seems weird to have a feature gate for that that isn't also gating index syntax at the same time, so I put them under the same feature gate. r? `@fee1-dead`

Constify `Index` traits tracking issue: rust-lang#143775 the `SliceIndex` trait cannot be implemented by users as it is sealed. While it would be useful for the `get` method on slices, it seems weird to have a feature gate for that that isn't also gating index syntax at the same time, so I put them under the same feature gate. r? ``@fee1-dead``

jieyouxu · 2025-07-15T01:33:03Z

Failed in rollup: #143947 (comment)

error[E0658]: cannot call conditionally-const method `core::slice::<impl [()]>::get_unchecked::<std::ops::Range<usize>>` in constants
##[error]  --> /checkout/tests/ui/consts/const-eval/ub-slice-get-unchecked.rs:7:29
   |
LL | const B: &[()] = unsafe { A.get_unchecked(3..1) };

@bors r-

oli-obk · 2025-07-15T08:27:41Z

@bors r=fee1-dead

bors · 2025-07-15T08:27:44Z

📌 Commit 2b4ede7 has been approved by fee1-dead

It is now in the queue for this repository.

bors · 2025-07-15T08:27:45Z

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

Constify `Index` traits tracking issue: rust-lang#143775 the `SliceIndex` trait cannot be implemented by users as it is sealed. While it would be useful for the `get` method on slices, it seems weird to have a feature gate for that that isn't also gating index syntax at the same time, so I put them under the same feature gate. r? `@fee1-dead`

Constify `Index` traits tracking issue: rust-lang#143775 the `SliceIndex` trait cannot be implemented by users as it is sealed. While it would be useful for the `get` method on slices, it seems weird to have a feature gate for that that isn't also gating index syntax at the same time, so I put them under the same feature gate. r? ``@fee1-dead``

Constify `Index` traits tracking issue: rust-lang#143775 the `SliceIndex` trait cannot be implemented by users as it is sealed. While it would be useful for the `get` method on slices, it seems weird to have a feature gate for that that isn't also gating index syntax at the same time, so I put them under the same feature gate. r? ```@fee1-dead```

Constify `Index` traits tracking issue: rust-lang#143775 the `SliceIndex` trait cannot be implemented by users as it is sealed. While it would be useful for the `get` method on slices, it seems weird to have a feature gate for that that isn't also gating index syntax at the same time, so I put them under the same feature gate. r? ````@fee1-dead````

Constify `Index` traits tracking issue: rust-lang#143775 the `SliceIndex` trait cannot be implemented by users as it is sealed. While it would be useful for the `get` method on slices, it seems weird to have a feature gate for that that isn't also gating index syntax at the same time, so I put them under the same feature gate. r? `````@fee1-dead`````

Rollup of 12 pull requests Successful merges: - #142936 (rustdoc-json: Structured attributes) - #143355 (wrapping shift: remove first bitmask and table) - #143448 (remote-test-client: Exit code `128 + <signal-number>` instead of `3`) - #143692 (miri: fix out-of-bounds error for ptrs with negative offsets) - #143719 (Emit warning when there is no space between `-o` and arg) - #143738 (Move several float tests to floats/mod.rs) - #143891 (Port `#[coverage]` to the new attribute system) - #143920 (Make more of codegen_llvm safe) - #143921 (Constify `Index` traits) - #143939 (Add 0323pin as maintainer of NetBSD targets, fix link to pkgsrc-wip and explain.) - #143948 (Update mdbook to 0.4.52) - #143968 (Add tracing to `InterpCx::fn_abi_of_instance/fn_abi_of_fn_ptr`) r? `@ghost` `@rustbot` modify labels: rollup

Constify `Index` traits tracking issue: rust-lang#143775 the `SliceIndex` trait cannot be implemented by users as it is sealed. While it would be useful for the `get` method on slices, it seems weird to have a feature gate for that that isn't also gating index syntax at the same time, so I put them under the same feature gate. r? ``````@fee1-dead``````

Rollup of 13 pull requests Successful merges: - #142936 (rustdoc-json: Structured attributes) - #143355 (wrapping shift: remove first bitmask and table) - #143448 (remote-test-client: Exit code `128 + <signal-number>` instead of `3`) - #143692 (miri: fix out-of-bounds error for ptrs with negative offsets) - #143719 (Emit warning when there is no space between `-o` and arg) - #143738 (Move several float tests to floats/mod.rs) - #143920 (Make more of codegen_llvm safe) - #143921 (Constify `Index` traits) - #143939 (Add 0323pin as maintainer of NetBSD targets, fix link to pkgsrc-wip and explain.) - #143948 (Update mdbook to 0.4.52) - #143957 (tidy: check for invalid file names) - #143968 (Add tracing to `InterpCx::fn_abi_of_instance/fn_abi_of_fn_ptr`) - #143990 (Add LocalKey<Cell>::update) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 12 pull requests Successful merges: - #142936 (rustdoc-json: Structured attributes) - #143355 (wrapping shift: remove first bitmask and table) - #143448 (remote-test-client: Exit code `128 + <signal-number>` instead of `3`) - #143692 (miri: fix out-of-bounds error for ptrs with negative offsets) - #143738 (Move several float tests to floats/mod.rs) - #143920 (Make more of codegen_llvm safe) - #143921 (Constify `Index` traits) - #143939 (Add 0323pin as maintainer of NetBSD targets, fix link to pkgsrc-wip and explain.) - #143948 (Update mdbook to 0.4.52) - #143957 (tidy: check for invalid file names) - #143968 (Add tracing to `InterpCx::fn_abi_of_instance/fn_abi_of_fn_ptr`) - #143990 (Add LocalKey<Cell>::update) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #143921 - oli-obk:const-index, r=fee1-dead Constify `Index` traits tracking issue: #143775 the `SliceIndex` trait cannot be implemented by users as it is sealed. While it would be useful for the `get` method on slices, it seems weird to have a feature gate for that that isn't also gating index syntax at the same time, so I put them under the same feature gate. r? ```````@fee1-dead```````

Rollup of 12 pull requests Successful merges: - rust-lang/rust#142936 (rustdoc-json: Structured attributes) - rust-lang/rust#143355 (wrapping shift: remove first bitmask and table) - rust-lang/rust#143448 (remote-test-client: Exit code `128 + <signal-number>` instead of `3`) - rust-lang/rust#143692 (miri: fix out-of-bounds error for ptrs with negative offsets) - rust-lang/rust#143738 (Move several float tests to floats/mod.rs) - rust-lang/rust#143920 (Make more of codegen_llvm safe) - rust-lang/rust#143921 (Constify `Index` traits) - rust-lang/rust#143939 (Add 0323pin as maintainer of NetBSD targets, fix link to pkgsrc-wip and explain.) - rust-lang/rust#143948 (Update mdbook to 0.4.52) - rust-lang/rust#143957 (tidy: check for invalid file names) - rust-lang/rust#143968 (Add tracing to `InterpCx::fn_abi_of_instance/fn_abi_of_fn_ptr`) - rust-lang/rust#143990 (Add LocalKey<Cell>::update) r? `@ghost` `@rustbot` modify labels: rollup

Constify `Index` traits tracking issue: rust-lang#143775 the `SliceIndex` trait cannot be implemented by users as it is sealed. While it would be useful for the `get` method on slices, it seems weird to have a feature gate for that that isn't also gating index syntax at the same time, so I put them under the same feature gate. r? ```````@fee1-dead```````

…eltardieu Rollup of 12 pull requests Successful merges: - rust-lang#142936 (rustdoc-json: Structured attributes) - rust-lang#143355 (wrapping shift: remove first bitmask and table) - rust-lang#143448 (remote-test-client: Exit code `128 + <signal-number>` instead of `3`) - rust-lang#143692 (miri: fix out-of-bounds error for ptrs with negative offsets) - rust-lang#143738 (Move several float tests to floats/mod.rs) - rust-lang#143920 (Make more of codegen_llvm safe) - rust-lang#143921 (Constify `Index` traits) - rust-lang#143939 (Add 0323pin as maintainer of NetBSD targets, fix link to pkgsrc-wip and explain.) - rust-lang#143948 (Update mdbook to 0.4.52) - rust-lang#143957 (tidy: check for invalid file names) - rust-lang#143968 (Add tracing to `InterpCx::fn_abi_of_instance/fn_abi_of_fn_ptr`) - rust-lang#143990 (Add LocalKey<Cell>::update) r? `@ghost` `@rustbot` modify labels: rollup

Constify `Index` traits tracking issue: rust-lang#143775 the `SliceIndex` trait cannot be implemented by users as it is sealed. While it would be useful for the `get` method on slices, it seems weird to have a feature gate for that that isn't also gating index syntax at the same time, so I put them under the same feature gate. r? ```````@fee1-dead```````

rustbot assigned fee1-dead Jul 14, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 14, 2025

fee1-dead approved these changes Jul 14, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 14, 2025

Kobzol mentioned this pull request Jul 14, 2025

Rollup of 14 pull requests #143946

Closed

Kobzol mentioned this pull request Jul 14, 2025

Rollup of 7 pull requests #143947

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 15, 2025

oli-obk added 3 commits July 15, 2025 07:44

constify SliceIndex trait

b5230e5

constify some methods using SliceIndex

cb7d52f

constify Index trait and its slice impls

2b4ede7

oli-obk force-pushed the const-index branch from 8b350d5 to 2b4ede7 Compare July 15, 2025 08:27

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 15, 2025

samueltardieu mentioned this pull request Jul 15, 2025

Rollup of 12 pull requests #143974

Closed

samueltardieu mentioned this pull request Jul 15, 2025

Rollup of 11 pull requests #143976

Closed

samueltardieu mentioned this pull request Jul 15, 2025

Rollup of 11 pull requests #143978

Closed

samueltardieu mentioned this pull request Jul 15, 2025

Rollup of 10 pull requests #143982

Closed

samueltardieu mentioned this pull request Jul 15, 2025

Rollup of 12 pull requests #143983

Closed

samueltardieu mentioned this pull request Jul 16, 2025

Rollup of 13 pull requests #144017

Closed

samueltardieu mentioned this pull request Jul 16, 2025

Rollup of 12 pull requests #144028

Merged

bors merged commit 9eda137 into rust-lang:master Jul 16, 2025
11 checks passed

rustbot added this to the 1.90.0 milestone Jul 16, 2025

oli-obk deleted the const-index branch July 17, 2025 07:43

oli-obk mentioned this pull request Jul 20, 2025

Tracking Issue for const_index #143775

Open

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Constify `Index` traits#143921

Constify `Index` traits#143921
bors merged 3 commits intorust-lang:masterfrom
oli-obk:const-index

oli-obk commented Jul 14, 2025 •

edited by rustbot

Loading

Uh oh!

fee1-dead left a comment

Uh oh!

fee1-dead commented Jul 14, 2025

Uh oh!

bors commented Jul 14, 2025

Uh oh!

jieyouxu commented Jul 15, 2025

Uh oh!

oli-obk commented Jul 15, 2025

Uh oh!

bors commented Jul 15, 2025

Uh oh!

bors commented Jul 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

oli-obk commented Jul 14, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fee1-dead left a comment

Choose a reason for hiding this comment

Uh oh!

fee1-dead commented Jul 14, 2025

Uh oh!

bors commented Jul 14, 2025

Uh oh!

jieyouxu commented Jul 15, 2025

Uh oh!

oli-obk commented Jul 15, 2025

Uh oh!

bors commented Jul 15, 2025

Uh oh!

bors commented Jul 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

oli-obk commented Jul 14, 2025 •

edited by rustbot

Loading