add AnonConstKind to non_trivial_const_arg diagnostics#144324
Draft
dvtkrlbs wants to merge 4 commits intorust-lang:mainfrom
Draft
add AnonConstKind to non_trivial_const_arg diagnostics#144324dvtkrlbs wants to merge 4 commits intorust-lang:mainfrom
dvtkrlbs wants to merge 4 commits intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
rustbot
added
S-waiting-on-author
dvtkrlbs
commented
Jul 22, 2025
| f: impl FnOnce(&mut Self), | ||
| ) { | ||
| let f = |this: &mut Self| { | ||
| this.with_rib(ValueNS, RibKind::ConstantItem(may_use_generics, item), |this| { |
Contributor
Author
There was a problem hiding this comment.
Really not sure bout this one since it is nested ConstantItems
| .sess | ||
| .is_nightly_build() | ||
| .then_some(errors::ParamInNonTrivialAnonConstHelp), | ||
| place: AnonConstKind::InlineConst, |
Contributor
Author
There was a problem hiding this comment.
There is no context here so I am just defaulting to InlineConst. I need to fix this
dvtkrlbs
force-pushed
the
non-trivial-const-arg
branch
from
ae7ce72 to
4669414
Compare
Collaborator
|
☔ The latest upstream changes (presumably #129183) made this pull request unmergeable. Please resolve the merge conflicts. |
Member
|
@dvtkrlbs any updates on this? thanks |
Contributor
Author
|
Lemme try to rebase it this week. I need a review and a small guidance on some of the diagnostics. |
dvtkrlbs
force-pushed
the
non-trivial-const-arg
branch
from
4669414 to
487627c
Compare
Contributor
Author
|
@Dylan-DPC sorry for late come back to this. I rebased the branch there is still some issues with the diagnostic logic I need some pointer |
Collaborator
|
☔ The latest upstream changes (presumably #150638) made this pull request unmergeable. Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#142387
r? @compiler-errors
one thing I am not sure about is if AnonConstKind is always available (if not not sure how to make it optional since IntoDiagArg is not implemented for Option). Especially in one of the late diagnostics there is no context to add AnonConstKind to an error (some diagnostics about lifetimes).