thread name in stack overflow message

[joboet]

Fixes #144481, which is caused by the thread name not being initialised yet when setting up the stack overflow information. Unfortunately, the stack overflow UI test did not test for the correct thread name being present, and testing this separately didn't occur to me when writing #140628.

This PR contains the smallest possible fix I could think of: passing the thread name explicitly to the platform thread creation function. In the future I'd very much like to explore some possibilities around merging the thread packet and thread handle into one structure and using that in the platform code instead – but that's best left for another PR.

This PR also amends the stack overflow test to check for thread names, so we don't run into this again.

@rustbot label +beta-nominated

[rustbot]

r? @ChrisDenton

rustbot has assigned @ChrisDenton.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[benesch]

My review here isn't worth very much, but from what I do know this looks great. Thank you so much for fixing this so quickly, @joboet!

[ChrisDenton]

This looks fair enough as a quick fix.

@bors r+

[bors]

📌 Commit dccafab has been approved by ChrisDenton

It is now in the queue for this repository.

[ChrisDenton]

@rust-lang/libs we're nearing a release so it'd be good to have a backport decision asap.

[matthiaskrgr]

@bors r-
#144508 (comment)

[benesch]

Looks like there's an alternative implementation of Thread::new for WASI that's compiled when atomics are disabled that also needs to be adjusted to take name as a parameter:

rust/library/std/src/sys/pal/wasi/thread.rs

Lines 123 to 125 in dccafab

	pub unsafe fn new(_stack: usize, _p: Box<dyn FnOnce()>) -> io::Result<Thread> {
	crate::sys::unsupported()
	}

[joboet]

@bors r=@ChrisDenton

[bors]

📌 Commit 73751a0 has been approved by ChrisDenton

It is now in the queue for this repository.