std: move `thread` into `sys` by joboet · Pull Request #145177 · rust-lang/rust

joboet · 2025-08-09T17:48:01Z

rustbot · 2025-08-09T17:48:05Z

rustbot has assigned @ChrisDenton.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2025-08-09T21:40:50Z

The Miri subtree was changed

cc @rust-lang/miri

bors · 2025-08-15T20:03:13Z

☔ The latest upstream changes (presumably #145450) made this pull request unmergeable. Please resolve the merge conflicts.

ChrisDenton · 2025-08-23T07:56:40Z

Sorry for the delay, I'm not keeping on top of my review queue right now so I'll assign someone else.

r? libs

joboet · 2025-08-29T18:39:30Z

I've split out the renaming part into a separate commit in order to simplify the diff. Unfortunately, the UNIX one is still rather large due to the amount of code movement. https://semanticdiff.com/ makes it nice and simple, but unfortunately requires signing in so I can't share a link (maybe someone knows of a better alternative?).

bors · 2025-09-03T18:38:15Z

☔ The latest upstream changes (presumably #146160) made this pull request unmergeable. Please resolve the merge conflicts.

ibraheemdev · 2025-09-03T23:08:48Z

This looks good. r=me after the rebase.

rustbot · 2025-09-08T15:12:40Z

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

joboet · 2025-09-08T16:43:39Z

@bors r=@ibraheemdev

joboet · 2025-09-10T13:28:12Z

@bors r=@ibraheemdev rollup=never

bors · 2025-09-10T13:28:15Z

📌 Commit f049b61 has been approved by ibraheemdev

It is now in the queue for this repository.

std: move `thread` into `sys` Part of #117276.

bors · 2025-09-11T12:08:36Z

⌛ Testing commit f049b61 with merge 054fa65...

rust-log-analyzer · 2025-09-11T12:53:39Z

The job dist-i686-msvc failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

bors · 2025-09-11T12:54:33Z

💔 Test failed - checks-actions

joboet · 2025-09-11T12:58:53Z

That was a spurious failure...
@bors retry

bors · 2025-09-11T22:31:47Z

⌛ Testing commit f049b61 with merge 2a9bacf...

bors · 2025-09-12T01:34:25Z

☀️ Test successful - checks-actions
Approved by: ibraheemdev
Pushing 2a9bacf to master...

github-actions · 2025-09-12T01:37:12Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 5eda692 (parent) -> 2a9bacf (this PR)

Test differences

No test diffs found

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 2a9bacf6187685931d52346a0ecff2e52bdc91cc --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-apple-various: 4687.7s -> 3152.1s (-32.8%)
dist-aarch64-apple: 7911.0s -> 8829.8s (11.6%)
dist-ohos-armv7: 4000.9s -> 4341.6s (8.5%)
dist-i686-msvc: 7655.5s -> 8191.3s (7.0%)
x86_64-msvc-ext1: 7454.3s -> 7969.2s (6.9%)
dist-various-1: 4143.4s -> 3898.6s (-5.9%)
dist-armhf-linux: 5190.3s -> 4885.4s (-5.9%)
x86_64-gnu-llvm-19: 2605.1s -> 2455.2s (-5.8%)
x86_64-gnu-llvm-19-2: 5806.3s -> 5482.1s (-5.6%)
dist-aarch64-msvc: 5942.2s -> 5611.8s (-5.6%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-09-12T04:11:34Z

Finished benchmarking commit (2a9bacf): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.7%	[-0.9%, -0.6%]	2
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (secondary 3.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.2%	[2.2%, 4.7%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results (primary 2.0%, secondary 3.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.0%	[2.0%, 2.0%]	1
Regressions ❌ (secondary)	3.1%	[2.1%, 4.1%]	8
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.0%	[2.0%, 2.0%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 467.659s -> 467.159s (-0.11%)
Artifact size: 387.85 MiB -> 387.82 MiB (-0.01%)

…=joboet Fix unsupported `std::sys::thread` after move Fixes building std for any platform with an unsupported thread abstraction. This includes {aarch64,armv7,x86_64}-unknown-trusty and riscv32im-risc0-zkvm-elf, which explicitly include the unsupported module, and platforms with no PAL. Bug fix for rust-lang#145177 (std: move thread into sys). Also fix the `std` build for xtensa, which I incidentally found while looking for an unsupported platform. r? `@joboet`

…=joboet Fix unsupported `std::sys::thread` after move Fixes building std for any platform with an unsupported thread abstraction. This includes {aarch64,armv7,x86_64}-unknown-trusty and riscv32im-risc0-zkvm-elf, which explicitly include the unsupported module, and platforms with no PAL. Bug fix for rust-lang#145177 (std: move thread into sys). Also fix the `std` build for xtensa, which I incidentally found while looking for an unsupported platform. r? ``@joboet``

Rollup merge of #146800 - thaliaarchi:fix-move-pal-thread, r=joboet Fix unsupported `std::sys::thread` after move Fixes building std for any platform with an unsupported thread abstraction. This includes {aarch64,armv7,x86_64}-unknown-trusty and riscv32im-risc0-zkvm-elf, which explicitly include the unsupported module, and platforms with no PAL. Bug fix for #145177 (std: move thread into sys). Also fix the `std` build for xtensa, which I incidentally found while looking for an unsupported platform. r? ``@joboet``

Fix unsupported `std::sys::thread` after move Fixes building std for any platform with an unsupported thread abstraction. This includes {aarch64,armv7,x86_64}-unknown-trusty and riscv32im-risc0-zkvm-elf, which explicitly include the unsupported module, and platforms with no PAL. Bug fix for rust-lang/rust#145177 (std: move thread into sys). Also fix the `std` build for xtensa, which I incidentally found while looking for an unsupported platform. r? ``@joboet``

…=joboet Fix unsupported `std::sys::thread` after move Fixes building std for any platform with an unsupported thread abstraction. This includes {aarch64,armv7,x86_64}-unknown-trusty and riscv32im-risc0-zkvm-elf, which explicitly include the unsupported module, and platforms with no PAL. Bug fix for rust-lang#145177 (std: move thread into sys). Also fix the `std` build for xtensa, which I incidentally found while looking for an unsupported platform. r? ``@joboet``

std: move `thread` into `sys` Part of rust-lang#117276.

…=joboet Fix unsupported `std::sys::thread` after move Fixes building std for any platform with an unsupported thread abstraction. This includes {aarch64,armv7,x86_64}-unknown-trusty and riscv32im-risc0-zkvm-elf, which explicitly include the unsupported module, and platforms with no PAL. Bug fix for rust-lang#145177 (std: move thread into sys). Also fix the `std` build for xtensa, which I incidentally found while looking for an unsupported platform. r? ``@joboet``

rustbot assigned ChrisDenton Aug 9, 2025

joboet mentioned this pull request Aug 9, 2025

Tracking Issue for restructuring std::sys #117276

Open

30 tasks

This comment has been minimized.

Sign in to view

rustbot assigned ibraheemdev and unassigned ChrisDenton Aug 23, 2025

joboet force-pushed the move-pal-thread branch from 8c26010 to f6ae04a Compare August 29, 2025 15:30

This comment has been minimized.

Sign in to view

joboet force-pushed the move-pal-thread branch 2 times, most recently from 793af86 to 10844c3 Compare August 29, 2025 16:49

std: move thread into sys (rename only)

4b15dd5

joboet force-pushed the move-pal-thread branch from 10844c3 to 078cc24 Compare September 8, 2025 15:12

joboet force-pushed the move-pal-thread branch from 27b1936 to f049b61 Compare September 10, 2025 13:27

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 10, 2025

bors added a commit that referenced this pull request Sep 11, 2025

Auto merge of #145177 - joboet:move-pal-thread, r=ibraheemdev

054fa65

std: move `thread` into `sys` Part of #117276.

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 11, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 11, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 12, 2025

bors merged commit 2a9bacf into rust-lang:master Sep 12, 2025
11 checks passed

rustbot added this to the 1.91.0 milestone Sep 12, 2025

thaliaarchi mentioned this pull request Sep 20, 2025

Fix unsupported std::sys::thread after move #146800

Merged

github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Oct 9, 2025

Auto merge of rust-lang#145177 - joboet:move-pal-thread, r=ibraheemdev

b97dbbc

std: move `thread` into `sys` Part of rust-lang#117276.

erickt mentioned this pull request Jan 27, 2026

Remove Fuchsia from target OS list in unix.rs for sleep #151706

Merged

Uh oh!

Conversation

joboet commented Aug 9, 2025

Uh oh!

rustbot commented Aug 9, 2025

Uh oh!

This comment has been minimized.

rustbot commented Aug 9, 2025

Uh oh!

bors commented Aug 15, 2025

Uh oh!

ChrisDenton commented Aug 23, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

joboet commented Aug 29, 2025

Uh oh!

bors commented Sep 3, 2025

Uh oh!

ibraheemdev commented Sep 3, 2025

Uh oh!

rustbot commented Sep 8, 2025

Uh oh!

joboet commented Sep 8, 2025

Uh oh!

joboet commented Sep 10, 2025

Uh oh!

bors commented Sep 10, 2025

Uh oh!

bors commented Sep 11, 2025

Uh oh!

rust-log-analyzer commented Sep 11, 2025

Uh oh!

bors commented Sep 11, 2025

Uh oh!

joboet commented Sep 11, 2025

Uh oh!

bors commented Sep 11, 2025

Uh oh!

bors commented Sep 12, 2025

Uh oh!

Uh oh!

github-actions bot commented Sep 12, 2025

Test differences

Job duration changes

Uh oh!

rust-timer commented Sep 12, 2025

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants