Merged
Conversation
This will run all tests for `riscv64a23-unknown-linux-gnu` in a QEMU instance.
…u.md Co-authored-by: zachs18 <8355914+zachs18@users.noreply.github.com>
This reverts commit 289688c.
A small oversight in 0cb69de I noticed while reading.
Losslessly optimizes all of the PNG files in the repo. Done with: ``` oxipng -o max -a -s oxipng -o max --zopfli -a -s ```
This internal crate explicitly separates itself from the `rustc` workspace, but it is needed for `./x test clippy` to work, including its dependencies when building from a vendored `rustc-src` tarball.
Having `const fn`s that take a `mut &` was unstable until Rust 1.83. Because of this, not all methods on `FormattingOptions` were implemented as `const`. As this has been stabilized now, there is no reason not to have all methods `const`. Thanks to Ternvein for bringing this to my attention (see [1]). [1]: rust-lang#118117 (comment)
The underlying implementation of `LLVMCreateConstantRangeAttribute` assumes that each of `LowerWords` and `UpperWords` points to enough u64 values to define an integer of the specified bit-length, and will encounter UB if that is not the case. Our safe wrapper function always passes pointers to `[u64; 2]` arrays, regardless of the bit-length specified. That's fine in practice, because scalar primitives never exceed 128 bits, but it is technically a soundness hole in a safe function. We can close the soundness hole by explicitly asserting `size_bits <= 128`. This is effectively just a stricter version of the existing check that the value must be small enough to fit in `c_uint`.
It was too dangerous to cache by default, and was it causing real bugs.
remove deprecated Error::description in impls [libs-api permission](rust-lang/libs-team#615 (comment)) r? `@cuviper` or `@jhpratt`
Add aarch64_be-unknown-linux-musl target This PR adds a target definition for big-endian Aarch64 with musl-libc. cc `@Gelbpunkt`
…cv64a23-target, r=davidtwco Add new Tier-3 target: riscv64a23-unknown-linux-gnu MCP: [Tier 3 target proposal: riscv64a23-unknown-linux-gnu](rust-lang/compiler-team#894) Changes: - add new target: riscv64a23-unknown-linux-gnu - add target page
… r=SparrowLii Add parentheses for closure when suggesting calling closure Fixes rust-lang#145404
…davidtwco Losslessly optimize PNG files Losslessly optimizes all of the PNG files in the repo. Done with: ``` oxipng -o max -a -s oxipng -o max --zopfli -a -s ```
…enton Fix doc of `std::os::windows::io::BorrowedSocket::borrow_raw` A small oversight in 0cb69de I noticed while reading.
Always build miri for the host in `x run miri` Previously we were building Miri for the passed `--target`, which was wrong. Fixes: rust-lang#145839 r? `@jieyouxu`
bootstrap: vendor `clippy_test_deps` too This internal crate explicitly separates itself from the `rustc` workspace, but it is needed for `./x test clippy` to work, including its dependencies when building from a vendored `rustc-src` tarball.
…0250825, r=m-ou-se formatting_options: Make all methods `const` Related to rust-lang#118117. Having `const fn`s that take a `mut &` was unstable until Rust 1.83 (see rust-lang#129195). Because of this, not all methods on `FormattingOptions` were implemented as `const`. As this has been stabilized now, there is no reason not to have all methods `const`. Thanks to `@Ternvein` for bringing this to my attention (see [1]). r? `@m-ou-se` (As you were the reviewer for the original implementation – feel free to reroll if you are busy or if you aren't interested) [1]: rust-lang#118117 (comment)
cg_llvm: Assert that LLVM range-attribute values don't exceed 128 bits The underlying implementation of `LLVMCreateConstantRangeAttribute` assumes that each of `LowerWords` and `UpperWords` points to enough u64 values to define an integer of the specified bit-length, and will encounter UB if that is not the case. Our safe wrapper function always passes pointers to `[u64; 2]` arrays, regardless of the bit-length specified. That's fine in practice, because scalar primitives never exceed 128 bits, but it is technically a soundness hole in a safe function. We can close the soundness hole by explicitly asserting `size_bits <= 128`. This is effectively just a stricter version of the existing check that the value must be small enough to fit in `c_uint`. --- This is a narrower version of the fix in rust-lang#145846.
rustbot
added
O-hermit
Member
Author
|
@bors r+ p=5 rollup=never |
Collaborator
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
📌 Perf builds for each rolled up PR:
previous master: 5ab69249f3 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 5ab6924 (parent) -> 91ee6a4 (this PR) Test differencesShow 215 test diffsStage 0
Stage 1
Stage 2
Additionally, 206 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 91ee6a4057ce4bf1ab6d2f932cae497488d67c81 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
This was referenced Aug 26, 2025
Collaborator
|
Finished benchmarking commit (91ee6a4): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 0.7%, secondary 3.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 4.2%, secondary -0.6%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary -0.1%, secondary -0.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 466.377s -> 469.036s (0.57%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
std::os::windows::io::BorrowedSocket::borrow_raw#145615 (Fix doc ofstd::os::windows::io::BorrowedSocket::borrow_raw)x run miri#145841 (Always build miri for the host inx run miri)clippy_test_depstoo #145861 (bootstrap: vendorclippy_test_depstoo)const#145863 (formatting_options: Make all methodsconst)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup