Skip to content

Conversation

@GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Jan 21, 2026

Fixes #151411.

Seems like the ICE was already solved by #151255. Well in any case, more regression tests won't hurt.

r? @lolbinarycat

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jan 21, 2026
@rustbot

This comment has been minimized.

@GuillaumeGomez GuillaumeGomez changed the title Add regression test for #151411 [rustdoc] Add regression test for #151411 Jan 21, 2026
@lolbinarycat
Copy link
Contributor

lolbinarycat commented Jan 27, 2026

There should probably be a comment somewhere saying this is a regression test for this specific ICE, but other than that looks solid, always happy to see more thorough testing.

@GuillaumeGomez GuillaumeGomez force-pushed the regression-test-for-151411 branch from 4bf9c83 to bfceb97 Compare January 27, 2026 21:46
@rustbot

This comment has been minimized.

@GuillaumeGomez
Copy link
Member Author

Added the comment.

@lolbinarycat
Copy link
Contributor

Yeah that's better.

Thanks!

@bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 27, 2026

📌 Commit bfceb97 has been approved by lolbinarycat

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 27, 2026
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 27, 2026
…-151411, r=lolbinarycat

[rustdoc] Add regression test for rust-lang#151411

Fixes rust-lang#151411.

Seems like the ICE was already solved by rust-lang#151255. Well in any case, more regression tests won't hurt.

r? @lolbinarycat
rust-bors bot pushed a commit that referenced this pull request Jan 27, 2026
Rollup of 6 pull requests

Successful merges:

 - #150893 (offload: move (un)register lib into global_ctors)
 - #151013 (Add some clarifications and fixes for fmt syntax)
 - #151449 ([rustdoc] Add regression test for #151411)
 - #151666 (compiler: Rename several types/traits for per-query vtables)
 - #151738 (Add `extern crate core` to diagnostic tests)
 - #151759 (Update `browser-ui-test` version to `0.23.3`)
@rust-log-analyzer

This comment has been minimized.

@GuillaumeGomez
Copy link
Member Author

@bors r-

@rust-bors rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 27, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 27, 2026

Commit bfceb97 has been unapproved.

@GuillaumeGomez GuillaumeGomez force-pushed the regression-test-for-151411 branch from bfceb97 to 35ccf18 Compare January 27, 2026 23:23
@rustbot
Copy link
Collaborator

rustbot commented Jan 27, 2026

⚠️ Warning ⚠️

  • There are issue links (such as #123) in the commit messages of the following commits.
    Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.

@GuillaumeGomez
Copy link
Member Author

@bors r=lolbinarycat rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 27, 2026

📌 Commit 35ccf18 has been approved by lolbinarycat

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 27, 2026
@GuillaumeGomez
Copy link
Member Author

@bors r=lolbinarycat rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 27, 2026

📌 Commit 35ccf18 has been approved by lolbinarycat

It is now in the queue for this repository.

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jan 27, 2026
…-151411, r=lolbinarycat

[rustdoc] Add regression test for rust-lang#151411

Fixes rust-lang#151411.

Seems like the ICE was already solved by rust-lang#151255. Well in any case, more regression tests won't hurt.

r? @lolbinarycat
@jieyouxu
Copy link
Member

jieyouxu commented Jan 28, 2026

I think this failed in #151765 (comment)

@jieyouxu
Copy link
Member

@bors r-

@rust-bors rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 28, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 28, 2026

Commit 35ccf18 has been unapproved.

rust-bors bot pushed a commit that referenced this pull request Jan 28, 2026
Rollup of 6 pull requests

Successful merges:

 - #150893 (offload: move (un)register lib into global_ctors)
 - #151013 (Add some clarifications and fixes for fmt syntax)
 - #151449 ([rustdoc] Add regression test for #151411)
 - #151666 (compiler: Rename several types/traits for per-query vtables)
 - #151738 (Add `extern crate core` to diagnostic tests)
 - #151759 (Update `browser-ui-test` version to `0.23.3`)
@GuillaumeGomez
Copy link
Member Author

@jieyouxu Yep, hence why I r-ed the rollup and then pushed a fix here. 😉

@bors r=lolbinarycat rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 28, 2026

📌 Commit 35ccf18 has been approved by lolbinarycat

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 28, 2026
rust-bors bot pushed a commit that referenced this pull request Jan 28, 2026
…uwer

Rollup of 12 pull requests

Successful merges:

 - #150491 (resolve: Mark items under exported ambiguous imports as exported)
 - #150720 (Do not suggest `derive` if there is already an impl)
 - #150968 (compiler-builtins: Remove the no-f16-f128 feature)
 - #151493 ([RFC] rustc_parse: improve the error diagnostic for "missing let in let chain")
 - #151660 (Bump `std`'s `backtrace`'s `rustc-demangle`)
 - #151696 (Borrowck: Simplify SCC annotation computation, placeholder rewriting)
 - #151704 (Implement `set_output_kind` for Emscripten linker)
 - #151706 (Remove Fuchsia from target OS list in unix.rs for sleep)
 - #151769 (fix undefined behavior in VecDeque::splice)
 - #151779 (stdarch subtree update)
 - #151449 ([rustdoc] Add regression test for #151411)
 - #151773 (clean up checks for constant promotion of integer division/remainder operations)
@rust-bors rust-bors bot merged commit 775abf4 into rust-lang:main Jan 29, 2026
11 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Jan 29, 2026
rust-timer added a commit that referenced this pull request Jan 29, 2026
Rollup merge of #151449 - GuillaumeGomez:regression-test-for-151411, r=lolbinarycat

[rustdoc] Add regression test for #151411

Fixes #151411.

Seems like the ICE was already solved by #151255. Well in any case, more regression tests won't hurt.

r? @lolbinarycat
github-actions bot pushed a commit to rust-lang/compiler-builtins that referenced this pull request Jan 29, 2026
…uwer

Rollup of 12 pull requests

Successful merges:

 - rust-lang/rust#150491 (resolve: Mark items under exported ambiguous imports as exported)
 - rust-lang/rust#150720 (Do not suggest `derive` if there is already an impl)
 - rust-lang/rust#150968 (compiler-builtins: Remove the no-f16-f128 feature)
 - rust-lang/rust#151493 ([RFC] rustc_parse: improve the error diagnostic for "missing let in let chain")
 - rust-lang/rust#151660 (Bump `std`'s `backtrace`'s `rustc-demangle`)
 - rust-lang/rust#151696 (Borrowck: Simplify SCC annotation computation, placeholder rewriting)
 - rust-lang/rust#151704 (Implement `set_output_kind` for Emscripten linker)
 - rust-lang/rust#151706 (Remove Fuchsia from target OS list in unix.rs for sleep)
 - rust-lang/rust#151769 (fix undefined behavior in VecDeque::splice)
 - rust-lang/rust#151779 (stdarch subtree update)
 - rust-lang/rust#151449 ([rustdoc] Add regression test for rust-lang/rust#151411)
 - rust-lang/rust#151773 (clean up checks for constant promotion of integer division/remainder operations)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ICE]: rustdoc panics with "no resolutions for a doc link" when resolving intra-doc link in #[deprecated] note via glob re-export

5 participants