-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
[rustdoc] Add regression test for #151411 #151449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rustdoc] Add regression test for #151411 #151449
Conversation
This comment has been minimized.
This comment has been minimized.
|
There should probably be a comment somewhere saying this is a regression test for this specific ICE, but other than that looks solid, always happy to see more thorough testing. |
4bf9c83 to
bfceb97
Compare
This comment has been minimized.
This comment has been minimized.
|
Added the comment. |
|
Yeah that's better. Thanks! @bors r+ rollup |
…-151411, r=lolbinarycat [rustdoc] Add regression test for rust-lang#151411 Fixes rust-lang#151411. Seems like the ICE was already solved by rust-lang#151255. Well in any case, more regression tests won't hurt. r? @lolbinarycat
Rollup of 6 pull requests Successful merges: - #150893 (offload: move (un)register lib into global_ctors) - #151013 (Add some clarifications and fixes for fmt syntax) - #151449 ([rustdoc] Add regression test for #151411) - #151666 (compiler: Rename several types/traits for per-query vtables) - #151738 (Add `extern crate core` to diagnostic tests) - #151759 (Update `browser-ui-test` version to `0.23.3`)
This comment has been minimized.
This comment has been minimized.
|
@bors r- |
|
Commit bfceb97 has been unapproved. |
bfceb97 to
35ccf18
Compare
|
|
@bors r=lolbinarycat rollup |
|
@bors r=lolbinarycat rollup |
…-151411, r=lolbinarycat [rustdoc] Add regression test for rust-lang#151411 Fixes rust-lang#151411. Seems like the ICE was already solved by rust-lang#151255. Well in any case, more regression tests won't hurt. r? @lolbinarycat
|
I think this failed in #151765 (comment) |
|
@bors r- |
|
Commit 35ccf18 has been unapproved. |
Rollup of 6 pull requests Successful merges: - #150893 (offload: move (un)register lib into global_ctors) - #151013 (Add some clarifications and fixes for fmt syntax) - #151449 ([rustdoc] Add regression test for #151411) - #151666 (compiler: Rename several types/traits for per-query vtables) - #151738 (Add `extern crate core` to diagnostic tests) - #151759 (Update `browser-ui-test` version to `0.23.3`)
…uwer Rollup of 12 pull requests Successful merges: - #150491 (resolve: Mark items under exported ambiguous imports as exported) - #150720 (Do not suggest `derive` if there is already an impl) - #150968 (compiler-builtins: Remove the no-f16-f128 feature) - #151493 ([RFC] rustc_parse: improve the error diagnostic for "missing let in let chain") - #151660 (Bump `std`'s `backtrace`'s `rustc-demangle`) - #151696 (Borrowck: Simplify SCC annotation computation, placeholder rewriting) - #151704 (Implement `set_output_kind` for Emscripten linker) - #151706 (Remove Fuchsia from target OS list in unix.rs for sleep) - #151769 (fix undefined behavior in VecDeque::splice) - #151779 (stdarch subtree update) - #151449 ([rustdoc] Add regression test for #151411) - #151773 (clean up checks for constant promotion of integer division/remainder operations)
Rollup merge of #151449 - GuillaumeGomez:regression-test-for-151411, r=lolbinarycat [rustdoc] Add regression test for #151411 Fixes #151411. Seems like the ICE was already solved by #151255. Well in any case, more regression tests won't hurt. r? @lolbinarycat
…uwer Rollup of 12 pull requests Successful merges: - rust-lang/rust#150491 (resolve: Mark items under exported ambiguous imports as exported) - rust-lang/rust#150720 (Do not suggest `derive` if there is already an impl) - rust-lang/rust#150968 (compiler-builtins: Remove the no-f16-f128 feature) - rust-lang/rust#151493 ([RFC] rustc_parse: improve the error diagnostic for "missing let in let chain") - rust-lang/rust#151660 (Bump `std`'s `backtrace`'s `rustc-demangle`) - rust-lang/rust#151696 (Borrowck: Simplify SCC annotation computation, placeholder rewriting) - rust-lang/rust#151704 (Implement `set_output_kind` for Emscripten linker) - rust-lang/rust#151706 (Remove Fuchsia from target OS list in unix.rs for sleep) - rust-lang/rust#151769 (fix undefined behavior in VecDeque::splice) - rust-lang/rust#151779 (stdarch subtree update) - rust-lang/rust#151449 ([rustdoc] Add regression test for rust-lang/rust#151411) - rust-lang/rust#151773 (clean up checks for constant promotion of integer division/remainder operations)
Fixes #151411.
Seems like the ICE was already solved by #151255. Well in any case, more regression tests won't hurt.
r? @lolbinarycat