-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
Use function shims to make sure EII works on apple targets #151733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@bors try jobs=aarch64-apple |
This comment has been minimized.
This comment has been minimized.
Use function shims to make sure EII works on apple targets try-job: aarch64-apple
This comment has been minimized.
This comment has been minimized.
|
ah that's the rebase's fault |
|
try build can still be interesting if the other test succeeds, but idk if we'll fail too fast, lemme rebase |
14c4dda to
2fef4ab
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
@bors try cancel |
|
@bors try jobs=aarch64-apple |
|
Try build cancelled. Cancelled workflows: |
Use function shims to make sure EII works on apple targets try-job: aarch64-apple
This comment has been minimized.
This comment has been minimized.
|
💔 Test for 8a39723 failed: CI. Failed job:
|
This comment has been minimized.
This comment has been minimized.
|
right, things are named differently, maybe we just shouldn't print that |
2fef4ab to
acd2e87
Compare
|
@bors try jobs=aarch64-apple |
Use function shims to make sure EII works on apple targets try-job: aarch64-apple
This comment has been minimized.
This comment has been minimized.
|
doesn't need the envvars anymore now, but let's just run the try build |
|
r? @bjorn3 (if you feel comfortable with this one?) |
Use function shims to make sure EII works on apple targets (and generally accepts target-arch attributes)
Explainer: #146348 (comment)
Tracking issue: #125418
r? ghost