Skip to content

Conversation

@jdonszelmann
Copy link
Contributor

Use function shims to make sure EII works on apple targets (and generally accepts target-arch attributes)

Explainer: #146348 (comment)
Tracking issue: #125418

r? ghost

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 27, 2026
@jdonszelmann
Copy link
Contributor Author

@bors try jobs=aarch64-apple

@rust-bors

This comment has been minimized.

rust-bors bot pushed a commit that referenced this pull request Jan 27, 2026
Use function shims to make sure EII works on apple targets


try-job: aarch64-apple
@rust-log-analyzer

This comment has been minimized.

@jdonszelmann
Copy link
Contributor Author

ah that's the rebase's fault

@jdonszelmann
Copy link
Contributor Author

try build can still be interesting if the other test succeeds, but idk if we'll fail too fast, lemme rebase

@jdonszelmann jdonszelmann force-pushed the eii-on-apple branch 2 times, most recently from 14c4dda to 2fef4ab Compare January 27, 2026 12:17
@rustbot
Copy link
Collaborator

rustbot commented Jan 27, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@jdonszelmann
Copy link
Contributor Author

@bors try cancel

@jdonszelmann
Copy link
Contributor Author

@bors try jobs=aarch64-apple

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 27, 2026

Try build cancelled. Cancelled workflows:

rust-bors bot pushed a commit that referenced this pull request Jan 27, 2026
Use function shims to make sure EII works on apple targets


try-job: aarch64-apple
@rust-bors

This comment has been minimized.

@rust-bors rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 27, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 27, 2026

💔 Test for 8a39723 failed: CI. Failed job:

@rust-log-analyzer

This comment has been minimized.

@jdonszelmann
Copy link
Contributor Author

right, things are named differently, maybe we just shouldn't print that

@jdonszelmann
Copy link
Contributor Author

@bors try jobs=aarch64-apple

rust-bors bot pushed a commit that referenced this pull request Jan 27, 2026
Use function shims to make sure EII works on apple targets


try-job: aarch64-apple
@rust-bors

This comment has been minimized.

@jdonszelmann
Copy link
Contributor Author

doesn't need the envvars anymore now, but let's just run the try build

@jdonszelmann
Copy link
Contributor Author

r? @bjorn3 (if you feel comfortable with this one?)

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 27, 2026

☀️ Try build successful (CI)
Build commit: 4507d01 (4507d01fee12a8bb1cf2e7920c372dc7c7cc984a, parent: 94a0cd15f5976fa35e5e6784e621c04e9f958e57)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants